NEXTPY-645, Fixed bug where decimals where falsely marked as empty #174
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…r localizations that use comma as decimal separator
| @@ -4,7 +4,7 @@ | |||
| "moduleResolution": "node", | |||
| "target": "es5", | |||
| "module": "es2015", | |||
| "lib": ["es2015", "es2016", "es2017", "es2020", "dom"], | |||
| "lib": ["es2015", "es2016", "es2017", "es2020", "es2021", "dom"], | |||
There was a problem hiding this comment.
added es2021 because replaceAll was not supported in previous versions
RubenvandeKerkhof-isp
approved these changes
Oct 19, 2023
randywanga
approved these changes
Oct 19, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Decimals would be marked as empty when the value was below 0, zeroIsEmpty was true and the decimal separator was a comma. This has now been fixed.