Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed several window module api issues #109

Merged
merged 5 commits into from
Jan 2, 2022

Conversation

israel-dryer
Copy link
Owner

  • fixed issues caused by 'falsey' checks on Window and Toplevel parameters
  • fixed alpha on Linux
  • set platform checks on several platform specific parameters
  • updated logic for centering screen, prev method caused issues on Linux when setting alpha; this still does not account for titlebar height however
  • replaced height and width parameters with size parameter on Toplevel to be consistent with Window class. The old parameters are still accepted via kwargs. The original arguments were not getting passed to the superclass anyway, so this fixes a bug as well

@israel-dryer israel-dryer linked an issue Jan 2, 2022 that may be closed by this pull request
@israel-dryer israel-dryer merged commit 2abfeb4 into master Jan 2, 2022
@israel-dryer israel-dryer deleted the fix-several-windows-api-issues branch January 3, 2022 05:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Window API issues
1 participant