Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Exclude directories #10

Closed
ocumo opened this issue Jun 29, 2016 · 4 comments
Closed

Exclude directories #10

ocumo opened this issue Jun 29, 2016 · 4 comments
Assignees
@israel-lugo
Labels
enhancement
Milestone
capidup-1.1

Comments

@ocumo
Copy link

ocumo commented Jun 29, 2016

Hi,
Just a suggestion:
It would be useful to have an option to exclude directories. This would make it even more flexible.
Thanks a lot for this nice tool !!
@israel-lugo
Copy link
Owner

Hi there,

That's a good idea! I will implement it in the next release.

Thanks for the suggestion.

@israel-lugo israel-lugo added this to the capidup-1.1 milestone Jun 29, 2016
@ocumo
Copy link
Author

ocumo commented Jun 29, 2016

Thanks!
I actually have another idea, I 'll open another issue, then.
regards

@israel-lugo israel-lugo mentioned this issue Jun 30, 2016
Open
@israel-lugo
Copy link
Owner

Perhaps it would also be useful to exclude files, either by name or by glob pattern (*.zip and so on).

@ocumo
Copy link
Author

ocumo commented Jul 4, 2016

Well, now that you mention it, that looks like the next thing to ask...
and since we are there, if that's not abusing: what about regular expressions?
Regexes are always on the "advanced user" side, and in this context it may not be the more obvious use case as well, so priority for something like that might fit in the 'nice to have' instead?

israel-lugo added a commit that referenced this issue Sep 9, 2016
@israel-lugo
Implement regression tests for directory exclusion. See #10.
14714d4 
Actual functionality is still not implemented.

New file tests/test_excludes.py.
israel-lugo added a commit that referenced this issue Sep 9, 2016
@israel-lugo
Add hook to index_files_by_size to prune subdirs. See #10.
a35a85d 
Still need to implement the actual pruning.
israel-lugo added a commit that referenced this issue Sep 9, 2016
@israel-lugo
Implement regression tests for directory exclusion. See #10.
ca89609 
Actual functionality is still not implemented.

New file tests/test_excludes.py.
israel-lugo added a commit that referenced this issue Sep 9, 2016
@israel-lugo
find_duplicates_in_dirs: New parameter exclude_dirs. See #10.
761a0e0 
Add hook to index_files_by_size to prune subdirs.

Still need to implement the actual pruning.
@israel-lugo israel-lugo mentioned this issue Sep 10, 2016
Closed
@israel-lugo israel-lugo self-assigned this Sep 9, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@israel-lugo israel-lugo

Labels
enhancement
Projects
None yet
Milestone
capidup-1.1
Development

No branches or pull requests
2 participants
@ocumo @israel-lugo