Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

When opening a cloud save the selected route is not updated #1970

Closed
1 of 2 tasks
HarelM opened this issue Feb 7, 2024 · 2 comments
Closed
1 of 2 tasks

When opening a cloud save the selected route is not updated #1970

HarelM opened this issue Feb 7, 2024 · 2 comments
Labels
bug Low Nice to have or feature or a very edge case bug

Comments

@HarelM
Copy link
Member

HarelM commented Feb 7, 2024

What happened?

See below

What steps will reproduce the bug?

  1. Open a cloud save
  2. The selected route did not change

What I expect to happen

I expect the selected route (showing the statistics) to be the selected one

Platform

  • Israel Hiking Map app
  • Israel Hiking Map site in a browser

OS Name and Version

Any

Browser Name and Version

Any

Additional information

There is a question of what should we do when sharing multiple routes and not just a single one, but in case of a single one it's clear that we should open it, focus on it and set the selected route to be it, probably exiting edit mode if edit more was on.
In case of multiple routes, we can use the last one I guess.

@HarelM HarelM added bug Low Nice to have or feature or a very edge case bug labels Feb 7, 2024
@zstadler
Copy link
Member

I believe the original e-mail brings an additional issue

היי אנשים יקרים
בעיה קטנה: אני מתכנן מסלול ושולח לחברים בקבוצה
והם מעלים לנייד שלהם את המסלול
הבעיה היא שנשאר אצלם המסלול הקודם וכאשר הם מעלים את המסלול החדש הגרף גבהים והקילומטרים נשארים עם המסלול הישן ולא מתעדכנים. אני צריך על פעם לתזכר אותם שלמחוק את כל המסלולים ורק אז להעלות את התיכנון החדש😄

When a share link is opened, all current routes remain in the app. As a result, when many shares are opened by a "read-only" user, who is not very familiar with the app, the app accumulates a large number of concurrently-opened routes.

@HarelM HarelM closed this as completed in 7f0615d Mar 17, 2024
@HarelM
Copy link
Member Author

HarelM commented Mar 17, 2024

Fixing the broader issue of what should we do if a user has "too many" private routes is out of scope for this issue.
A proper UX discussion should be made before we decide how to solve it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Low Nice to have or feature or a very edge case bug
Projects
None yet
Development

No branches or pull requests

2 participants