Feedback #1
Feedback #1
Conversation
![github-classroom[bot]](https://avatars.githubusercontent.com/in/68187?s=60&v=4){kind=small}
index.html
Outdated
|
|
||
| <script src="./js/script.js"></script> | ||
| <script | ||
| src="https://cdn.jsdelivr.net/npm/bootstrap@5.3.0-alpha1/dist/js/bootstrap.bundle.min.js" |
There was a problem hiding this comment.
why import the JS part of bootstrap? do you use it?
| const resultsDiv = document.getElementById("resultsDiv"); | ||
| const loaderP = document.getElementById("loading"); | ||
|
|
||
| document.addEventListener("DOMContentLoaded", function (event) { |
There was a problem hiding this comment.
nice! consider setting deafult image in this case, instead of hiding it.
js/script.js
Outdated
| loaderP.style.display = "unset"; | ||
| }; | ||
|
|
||
| hideloader = () => { |
js/script.js
Outdated
| hideloader = () => { | ||
| loaderP.style.display = "none"; | ||
| }; | ||
| queryAdress = () => { |
|
|
||
| function getNameAndSymbol(name) { | ||
| let endpoint = | ||
| "https://stock-exchange-dot-full-stack-course-services.ew.r.appspot.com/api/v3/search?query=" + |
There was a problem hiding this comment.
use baseURL to store 'https://stock-exchange-dot-full-stack-course-services.ew.r.appspot.com/api/v3/' instead of rewriting it. DRY
js/script.js
Outdated
| .then((data) => { | ||
| let promises = []; | ||
| for (let i = 0; i < 10; i++) { | ||
| let clearedsymbol; |
| pEls[i].textContent = `Change: ${data.profile.changesPercentage}%`; | ||
| pEls[i].classList.add(changesNegPoz); | ||
| if (data.profile.changesPercentage > 0) { | ||
| pEls[i].innerHTML += ` <span style="color:green">▲</span>`; |
| @@ -0,0 +1,99 @@ | |||
| const queryParamOfThePage = new URLSearchParams(window.location.search).get( | |||
| const data = await response.json(); | ||
| const prices = data.historical.map((d) => d.close); | ||
| const dates = data.historical.map((d) => d.date); | ||
| const chart = new Chart(chartDraw, { |
| const tickerList = document.querySelector(".ticker-list"); | ||
| function MarqueeList() { | ||
| const tickerEndpoint = | ||
| "https://stock-exchange-dot-full-stack-course-services.ew.r.appspot.com/api/v3/quotes/nyse?exchange=NASDAQ"; |
| loadData(); | ||
|
|
||
| const tickerList = document.querySelector(".ticker-list"); | ||
| function MarqueeList() { |
There was a problem hiding this comment.
since this function is alredy written in script.js - instead of rewriting it, use another file for the shared logic (function and variables)
|
Hey Andrei, well done for submitting milestones 1-4. Overall you did good work here. The website functions as expected and you have all the required features. In addition to my specific comments over your code, I recommend you to work more on the cleanliness, readability and organization of your code. In addition, the UI you created is very unique - I suggest you to do some research about creating user interface that makes the user experience comfortable and easy to use. You can start from here : |
| </div> | ||
| <div class="col-4" id="searchDiv"> | ||
| <h3>.search_NASDAQ_stocks:</h3> | ||
| <input type="textbox" id="searchBox" /> |
There was a problem hiding this comment.
the input and submit button should be created inside the searchForm class
js/marquee.js
Outdated
| @@ -0,0 +1,24 @@ | |||
| const tickerList = document.querySelector(".ticker-list"); | |||
| function MarqueeList() { | |||
js/searchResults.js
Outdated
| const baseUrl = | ||
| "https://stock-exchange-dot-full-stack-course-services.ew.r.appspot.com/api/v3"; | ||
|
|
||
| function highlightText(text, searchTerm) { |
|
Hey Andrei, well done for submitting the project. Currently milestones 5 & 6 are missing, and since they are the main issue of this checking round this is not a good thing. I was pretty impressed from your code of milestones 1-4, hope to see more of it in the next projects... |
|
Tomer, hi! Wasn’t the task for milestone 5 to get the marquee in one file
and for milestone 6 to separate into two different files the search
function? Wasn’t that done?
Пн, 13 марта 2023 г. в 11:35, tomerp20 ***@***.***>:
Hey Andrei, well done for submitting the project. Currently milestones 5
& 6 are missing, and since they are the main issue of this checking round
this is not a good thing. I was pretty impressed from your code of
milestones 1-4, hope to see more of it in the next projects...
Good luck (:
—
Reply to this email directly, view it on GitHub
<#1 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/A4OF7WVKON2CM2327PQJVBLW33S5JANCNFSM6AAAAAAU7W7VHU>
.
You are receiving this because you were mentioned.Message ID:
<israeltechchallenge/js-second-project-stock-exchange-mironovisa/pull/1/c1465799381
@github.com>
--
С уважением,
Миронов Андрей Андреевич
Тел.: 8(965)151-14-14
|
|
Tomer? Did you get my previous message?
Пн, 13 марта 2023 г. в 12:22, ANDREI MIRONOV ***@***.***>:
Tomer, hi! Wasn’t the task for milestone 5 to get the marquee in one file
and for milestone 6 to separate into two different files the search
function? Wasn’t that done?
Пн, 13 марта 2023 г. в 11:35, tomerp20 ***@***.***>:
> Hey Andrei, well done for submitting the project. Currently milestones 5
> & 6 are missing, and since they are the main issue of this checking round
> this is not a good thing. I was pretty impressed from your code of
> milestones 1-4, hope to see more of it in the next projects...
> Good luck (:
>
> —
> Reply to this email directly, view it on GitHub
> <#1 (comment)>,
> or unsubscribe
> <https://github.com/notifications/unsubscribe-auth/A4OF7WVKON2CM2327PQJVBLW33S5JANCNFSM6AAAAAAU7W7VHU>
> .
> You are receiving this because you were mentioned.Message ID:
> <israeltechchallenge/js-second-project-stock-exchange-mironovisa/pull/1/c1465799381
> @github.com>
>
--
С уважением,
Миронов Андрей Андреевич
Тел.: 8(965)151-14-14
--
С уважением,
Миронов Андрей Андреевич
Тел.: 8(965)151-14-14
|
👋! GitHub Classroom created this pull request as a place for your teacher to leave feedback on your work. It will update automatically. Don’t close or merge this pull request, unless you’re instructed to do so by your teacher.
In this pull request, your teacher can leave comments and feedback on your code. Click the Subscribe button to be notified if that happens.
Click the Files changed or Commits tab to see all of the changes pushed to
mainsince the assignment started. Your teacher can see this too.Notes for teachers
Use this PR to leave feedback. Here are some tips:
mainsince the assignment started. To leave comments on specific lines of code, put your cursor over a line of code and click the blue + (plus sign). To learn more about comments, read “Commenting on a pull request”.main. Click a commit to see specific changes.For more information about this pull request, read “Leaving assignment feedback in GitHub”.
Subscribed: @mironovisa