Skip to content
This repository has been archived by the owner on May 5, 2019. It is now read-only.

Noted supporting PHP 7 #4

Merged
merged 1 commit into from
Dec 21, 2016
Merged

Noted supporting PHP 7 #4

merged 1 commit into from
Dec 21, 2016

Conversation

matsubo
Copy link
Contributor

@matsubo matsubo commented Dec 21, 2016

No description provided.

@issei-m
Copy link
Owner

issei-m commented Dec 21, 2016

I'm not sure it works on 7.1. I'm gonna test ASAP, so please wait awhile :)

@matsubo
Copy link
Contributor Author

matsubo commented Dec 21, 2016 •
edited
Loading

ok. Thanks.

It worked on my demo page using this library.
https://matsu.teraren.com/spike-api-demo-php/

  % php -v
PHP 7.1.0 (cli) (built: Dec  2 2016 11:32:42) ( NTS )
Copyright (c) 1997-2016 The PHP Group
Zend Engine v3.1.0-dev, Copyright (c) 1998-2016 Zend Technologies
    with Zend OPcache v7.1.0, Copyright (c) 1999-2016, by Zend Technologies
You have new mail.

issei-m added a commit that referenced this pull request Dec 21, 2016
@issei-m
Merge branch 'patch-1' of github.com:matsubo/spike-php into 7.1
0a3cb98 
---
#4
@issei-m
Copy link
Owner

issei-m commented Dec 21, 2016

Cool! Meanwhile, I also have confirmed it works fine on Travis: #5
This PR can be merged.

@issei-m issei-m merged commit e784ccd into issei-m:master Dec 21, 2016
@issei-m
Copy link
Owner

issei-m commented Dec 21, 2016

Thank you @matsubo

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@matsubo @issei-m