-
Notifications
You must be signed in to change notification settings - Fork 439
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Identifying the author of the document #82
Comments
You can do it yourself with a CSS rule that matches |
Can you describe how exactly this works? |
You can do this via JavaScript using something like |
Closing in favour of discussion in #321. Especially #321 (comment) is a nice solution. |
Re-opening until someone adds the proposed CSS solution to the docs. |
I think a badge next to the author's name plus a different name color would be better than a message background. I think it's easier than trying to deal with trying to make the background fit in with the visual style. |
As a first step to allow better styling, the author @BBaoVanC would you like to work on something like this? |
I'll try and see what I can do. I haven't ever done much with JS so for that part of the client I might need help. I'll make a draft PR if I can figure something out. |
That's what I mean: diff --git a/isso/js/app/templates/comment.js b/isso/js/app/templates/comment.js
index d0daf99..53738b2 100644
--- a/isso/js/app/templates/comment.js
+++ b/isso/js/app/templates/comment.js
@@ -9,7 +9,7 @@ var html = function (globals) {
var author = comment.author ? comment.author : i18n('comment-anonymous');
return "" +
-"<div class='isso-comment' id='isso-" + comment.id + "'>"
+"<div class='isso-comment' id='isso-" + comment.id + "' data-hash='" + comment.hash + "'>"
+ (conf.gravatar ? "<div class='isso-avatar'><img src='" + comment.gravatar_image + "'></div>" : '')
+ (conf.avatar ? "<div class='isso-avatar'><svg data-hash='" + comment.hash + "'</svg></div>" : '')
+ "<div class='isso-text-wrapper'>" You could then use |
Tracked in #844 |
It would be useful to identify the comments of author of the document (or, if it is difficult to do it per document, per website) which is commented, by looking at the email and the username for instance, with a chosen color for the background of the comments for example (and maybe some indication next to the username and some enhancement for the avatar).
.
The text was updated successfully, but these errors were encountered: