Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: install: Reorder Install from source, py3.5 #703

Merged
merged 2 commits into from
Dec 24, 2021

Conversation

ix5
Copy link
Member

@ix5 ix5 commented Feb 5, 2021

Reorder steps so that js files are generated before python setup.py develop.

Clarify that isso should be installed in editable mode when installed from source.
Clarify that sphinx is needed for docs, and only for docs.
Clarify that npm is definitely required.

Isso requires python 3.5 now.

docs/docs/install.rst Outdated Show resolved Hide resolved
Copy link
Member

@jelmer jelmer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See earlier comments.

Clarify that isso should be installed in editable mode when
installed from source.
Clarify that sphinx is needed for docs, and only for docs.
Clarify that npm is definitely required.

Isso requires python 3.5 now.
@ix5
Copy link
Member Author

ix5 commented Dec 24, 2021

Pushed with requested changes,

@jelmer jelmer merged commit 28beb7e into isso-comments:master Dec 24, 2021
@ix5 ix5 deleted the docs-install branch December 24, 2021 02:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants