-
Notifications
You must be signed in to change notification settings - Fork 439
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix GitHub actions #733
Fix GitHub actions #733
Conversation
Flask-Caching requires Flask. This should also fix posativ#621. See https://github.com/sh4nks/flask-caching/blob/cb6a7a3d61057b07ebdc7a58359b41257fe0af93/setup.py#L44-L44.
Dropping support for Pytohn 3.5 LGTM. I think we should support pypy3; perhaps we can just ignore the test results from pypy3 for now? |
Sure, how about Windows, MacOS and Python 3.9? (See the comment above.) |
I think we should run the tests for Windows and Mac OS but ignore the results for now. It would be good to include python3.9. |
I've included Python 3.9. For dropping support for Python 3.5. I'll create another PR. |
Is there something keeping these improvements from being merged? |
Thanks for the ping. No reason for not merging other than lack of time. I think we should drop the broken environments as suggested in the PR description, happy to do PRs that do so. |
This PR fixed the dependency issues that causes CI test to fail.
Unless isso explicitly supports Windows and PyPy3, I don't think we should include them in the CI test.
Also we should consider drop the support for Python 3.5 which reached end-of-life.
So, I think we can discuss the following changes: