Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix GitHub actions #733

Merged
merged 4 commits into from
Oct 24, 2021
Merged

Fix GitHub actions #733

merged 4 commits into from
Oct 24, 2021

Conversation

BookGin
Copy link
Contributor

@BookGin BookGin commented Jul 1, 2021

This PR fixed the dependency issues that causes CI test to fail.

Unless isso explicitly supports Windows and PyPy3, I don't think we should include them in the CI test.
Also we should consider drop the support for Python 3.5 which reached end-of-life.

So, I think we can discuss the following changes:

  • 1. Drop support for Python 3.5. I can create a another PR for this.
  • 2. Consider remove Windows tests
  • 3. Consider remove PyPy tests
  • 4. Consider remove MacOS tests, even though it works out of the box 馃槂
  • 5. Add Python 3.9, which is currently latest Python

@jelmer
Copy link
Member

jelmer commented Jul 3, 2021

Dropping support for Pytohn 3.5 LGTM.

I think we should support pypy3; perhaps we can just ignore the test results from pypy3 for now?

@BookGin
Copy link
Contributor Author

BookGin commented Jul 5, 2021

Sure, how about Windows, MacOS and Python 3.9? (See the comment above.)

@jelmer
Copy link
Member

jelmer commented Jul 5, 2021

I think we should run the tests for Windows and Mac OS but ignore the results for now. It would be good to include python3.9.

@BookGin
Copy link
Contributor Author

BookGin commented Jul 7, 2021

I've included Python 3.9. For dropping support for Python 3.5. I'll create another PR.

@aquatix
Copy link
Contributor

aquatix commented Oct 24, 2021

Is there something keeping these improvements from being merged?

@jelmer jelmer merged commit 9e021cb into isso-comments:master Oct 24, 2021
@jelmer
Copy link
Member

jelmer commented Oct 24, 2021

Thanks for the ping. No reason for not merging other than lack of time.

I think we should drop the broken environments as suggested in the PR description, happy to do PRs that do so.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants