Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert "Build JavaScript files during python package build" #798

Merged
merged 1 commit into from
Feb 17, 2022
Merged

Revert "Build JavaScript files during python package build" #798

merged 1 commit into from
Feb 17, 2022

Commits on Feb 17, 2022

  1. Revert "Build JavaScript files during python package build" 

    This reverts commit bbad14e.

Reason for revert:
The change broke `sdist` (source distribution) installs
(which will attempt to run `make` even when *installing*,
but neither `Makefile` nor `package.json` are inlcuded in
the tarball (see `MANIFEST.in`), so the command will fail.
    @ix5
    ix5 committed Feb 17, 2022
    Configuration menu
    Copy the full SHA
    437fcad View commit details
    Browse the repository at this point in the history