Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

setup.py: drop python3.5 support #808

Merged
merged 1 commit into from
Mar 27, 2022
Merged

setup.py: drop python3.5 support #808

merged 1 commit into from
Mar 27, 2022

Conversation

fliiiix
Copy link
Contributor

@fliiiix fliiiix commented Mar 6, 2022

Since not tests are run for 3.5 drop support
with the next release.
Also Python 3.5 has reached end-of-life on 5-Sep-2020.
Python 3.5.10 is the final release of 3.5.
https://www.python.org/downloads/release/python-3510/

@fliiiix
Copy link
Contributor Author

fliiiix commented Mar 6, 2022

Technically even 3.6 is unsupported but as long as there is no need to drop support i would argue its continent to still support it.

@fliiiix
Copy link
Contributor Author

fliiiix commented Mar 6, 2022

This change should probably be noted in some changelog?

@fliiiix fliiiix force-pushed the bugfix/drop-support-python3-5 branch from 3d2def0 to 47a78bb Compare March 6, 2022 14:14
@ix5 ix5 added this to the 0.13 milestone Mar 6, 2022
@ix5 ix5 added feature server (Python) server code labels Mar 6, 2022
@fliiiix fliiiix force-pushed the bugfix/drop-support-python3-5 branch from 47a78bb to 20cc541 Compare March 6, 2022 20:13
ix5
ix5 requested changes Mar 15, 2022
View reviewed changes
Copy link
Member

@ix5 ix5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please also change docs/docs/install.rst which mentions 3.5 as well

CHANGES.rst Outdated Show resolved Hide resolved
@ix5
Copy link
Member

ix5 commented Mar 15, 2022

Hey @fliiiix, you're also very welcome to join the #isso IRC channel, preferably via Matrix: #isso or on Libera.Chat directly.

@fliiiix
Copy link
Contributor Author

fliiiix commented Mar 16, 2022

I will update this PR hopefully on the weekend.

@ix5
Copy link
Member

ix5 commented Mar 21, 2022

While you're at it, maybe also test compatibility with 3.11 and advertise that?

@fliiiix
setup.py: drop python3.5 support
b5c71bf 
Since not tests are run for 3.5 drop support
with the next release.
Also Python 3.5 has reached end-of-life on 5-Sep-2020.
Python 3.5.10 is the final release of 3.5.
https://www.python.org/downloads/release/python-3510/
@fliiiix fliiiix force-pushed the bugfix/drop-support-python3-5 branch from 20cc541 to 1d5ada2 Compare March 27, 2022 17:42
@fliiiix fliiiix requested a review from ix5 March 27, 2022 17:42
@fliiiix fliiiix force-pushed the bugfix/drop-support-python3-5 branch from 1d5ada2 to b5c71bf Compare March 27, 2022 17:43
@fliiiix
Copy link
Contributor Author

fliiiix commented Mar 27, 2022

3.11 is not release yet so i would wait for the official release

@ix5 ix5 merged commit 79a7746 into isso-comments:master Mar 27, 2022
@ix5
Copy link
Member

ix5 commented Mar 27, 2022

3.11 is not release yet so i would wait for the official release

My thinking was that we can already put it into the GH actions test matrix before the release is out, but not yet adversise support in setup.py.

Doesn't matter too much though, merged.

@fliiiix fliiiix deleted the bugfix/drop-support-python3-5 branch March 28, 2022 08:15
@fliiiix
Copy link
Contributor Author

fliiiix commented Mar 28, 2022

create an extra pr for that #832

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ix5 ix5 Awaiting requested review from ix5

Assignees
No one assigned
Labels
feature server (Python) server code
Projects
None yet
Milestone
0.13
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@fliiiix @ix5