Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix issue on some system with right to extract the file if downloaded… #35

Merged

Conversation

Projects
None yet
2 participants
@Grummfy
Copy link
Contributor

commented Aug 13, 2018

Hello,
I use knife solo (and so chef-solo) to deploy this cookbook. But since it as change from ark to tar_extract, I got an issue with the extract part. To fix it, I just say where to download the archive (for now in the install_path).

I don't know if it's specific to solo mode or not, but I assume it's possible it impact some other people, so here is the fix.

@magicknot

This comment has been minimized.

Copy link
Member

commented Aug 13, 2018

Thank you for the fix! If you want to, you can also submit a pull request with some tests for chef-solo. I'll cut a release today with the fix (and the update for 5.1.1).

@magicknot magicknot merged commit 7fbf1f2 into ist-dsi:master Aug 13, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@Grummfy Grummfy deleted the Grummfy:fix/issue-related-to-download-dir-and-right branch Aug 13, 2018

@Grummfy

This comment has been minimized.

Copy link
Contributor Author

commented Aug 13, 2018

thanks. Well I didn't have enough skills in chef to make unit test for it, but if I find some other issue I will put it as PR or issue ;)

nice for the 5.1.1 \o/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.