Use pirates for require hooks.

[ariporad]

Hi!

As discussed in various issues (mainly istanbuljs/nyc#70), this PR uses pirates to implement require hooks. Pirates takes care of hooking require, so we don't have to. This makes the various require-related functions in this module mostly wrappers, but useful none the less.

This change is completely transparent (a patch version bump), and all the tests still pass.

[ariporad]

@gotwarlost: Ok, Breaking API changes have been dealt with! Pirates@2.0.0 has been published, and this PR has been updated! I hope you enjoy!

[ariporad]

@gotwarlost: Would it be possible to get this merged? If not, is there anything I could do to fix it? Thanks!

[ariporad]

@gotwarlost: bump.

[ariporad]

(This might not be the right place for this, but...)

Hey, @davglass, you work with @gotwarlost in real life, right? Do you have any idea where he might be? He appears to have disappeared. Thanks!

[gotwarlost]

Just on vacation for the past few weeks. Back now :)

Will look at istanbul related stuff next week since I have a few other things to finish before then

[ariporad]

@gotwarlost: Ok, Great! Thanks!

[ariporad]

@gotwarlost: bump.

[gotwarlost]

Sorry man, @jamestalmage 's writeup https://www.npmjs.com/package/append-transform convinced me that I need it too. The lack of 'append' is causing many bug reports even on the istanbul 1.x branch.

Closing this PR as a result. Sorry!

[ariporad]

Hey, no worries! Append-transform respects the chain, which is all I care about.

Thanks! Ari
On Sun, Jan 24, 2016 at 11:40 PM, istanbuljs/istanbul-lib-hook
reply@reply.github.com
wrote:
Closed #5 [https://github.com//pull/5] .

—
Reply to this email directly or view it on GitHub
[https://github.com//pull/5#event-524654080] .[https://github.com/notifications/beacon/ABu7pF-oqRCbphOgLshNvrRU3u4qzC5Eks5pdcjYgaJpZM4Gvk-T.gif]