Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplify cover variable naming #24

Merged
merged 1 commit into from Sep 13, 2016

Conversation

mourner
Copy link
Contributor

@mourner mourner commented Sep 8, 2016

A simpler and cleaner way to generate a hashed variable for cover stats — we take first 12 hex digits of sha1 digest and convert it to base36. I think the first 12 digits are more than enough to avoid any possible collisions — we could probably do away with less. cc @bcoe

// before
++__cov_bpZamYSu4YZDor3bpoXygHqmoUk.s[0];

// after
++cov_173mm3ogj2.s[0];

@yahoocla
Copy link

yahoocla commented Sep 8, 2016

CLA is valid!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants