New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Exclude option ignored unless in nyc stanza of package.json #62
Comments
I just recreated this as well. The |
@tteltrab @wKovacs64 I believe there's another issue open on nyc related to this; will dig soon, any help appreciated. |
@bcoe the issue is here: istanbuljs/nyc#419. |
Using nyc to instrument the files lead to false negatives, not to mention incorrect call count for lines in the HTML report. Switched to babel-plugin-istanbul. Had to move the `excluded` stanza from `.nycrc` to `.babelrc` because of istanbuljs/babel-plugin-istanbul#62
@321ckatz123 @wKovacs64 I believe we've landed a patch for this, could you give the following a try:
Thanks to @alpersogukpinar for identifying the underlying problem. |
@bcoe |
@bcoe me as well. When can we get this pushed to npm? |
@321ckatz123 the module is up, just not on latest yet; try this:
|
@bcoe, I understand how to get it now. I was more asking when is the next release (which I assume includes this) is going to get pushed? |
@wKovacs64 @321ckatz123 this is published to |
Using nyc to instrument the files lead to false negatives, not to mention incorrect call count for lines in the HTML report. Switched to babel-plugin-istanbul. Had to move the `excluded` stanza from `.nycrc` to `.babelrc` because of istanbuljs/babel-plugin-istanbul#62
Using nyc to instrument the files lead to false negatives, not to mention incorrect call count for lines in the HTML report. Switched to babel-plugin-istanbul. Had to move the `excluded` stanza from `.nycrc` to `.babelrc` because of istanbuljs/babel-plugin-istanbul#62
When using
babel-plugin-istanbul
, it appears if the nyc configuration object is included in thenyc
stanza ofpackage.json
, everything is fine. But when attempting to use the same options in.nycrc
or via the command-line, they are ignored (exclude
, in particular).Repro examples: https://github.com/wKovacs64/nyc-exclude-test(deleted)Side note: in my real projects where I first ran into this, I require
babel-register
with mocha as opposed to nyc. The nyc documentation does it in the nyc configuration, so that's what I used in my reproduction cases, but it doesn't appear to make a difference.The text was updated successfully, but these errors were encountered: