Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Update write-file-atomic #16

Merged
merged 1 commit into from
May 25, 2019

Conversation

coreyfarrell
Copy link
Member

The intent is to release caching-transform@4.0.0 with this change.

@coveralls
Copy link

coveralls commented May 24, 2019

Pull Request Test Coverage Report for Build 66

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 100.0%

Totals Coverage Status
Change from base Build 64: 0.0%
Covered Lines: 50
Relevant Lines: 50

💛 - Coveralls

Copy link
Member

@JaKXz JaKXz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If this is meant to be a breaking change, then it should be a fix! or feat! right?

I'm assuming of course there are breaking changes in write-file-atomic that affect caching-transform's functionality.

@coreyfarrell
Copy link
Member Author

write-file-atomic is semver-major for two reasons.

  1. It now requires node.js 8 (caching-transform#master already requires node.js 8)
  2. option.Promise has been removed (no effect here as we don't use the async interface)

So this is non-breaking for caching-transform (note no changes to any *.js file). Technically it doesn't make much of a difference though as this repo has never followed conventional-commits, the release will be manual. And yes I plan to use conventional-commits once this release is complete.

@JaKXz
Copy link
Member

JaKXz commented May 24, 2019

@coreyfarrell That's what I thought [from my cursory knowledge of the two packages]... That's why I think this should just be a patch release and be marked fix: update write-file-atomic.

@coreyfarrell
Copy link
Member Author

We're already in a semver-major cycle, we haven't released since node.js 6 was dropped.

@JaKXz
Copy link
Member

JaKXz commented May 24, 2019

Ah - I didn't know that..

@coreyfarrell
Copy link
Member Author

@JaKXz is this OK then?

@JaKXz JaKXz merged commit a930ae1 into istanbuljs:master May 25, 2019
@coreyfarrell coreyfarrell deleted the update-write-file-atomic branch May 26, 2019 13:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants