fix: parenthesize superClass on non-idetifier case (#158)

istanbuljs · May 31, 2018 · 6202c88 · 6202c88
1 parent ce23e91
commit 6202c88
Show file tree

Hide file tree

Showing 2 changed files with 14 additions and 6 deletions.
diff --git a/packages/istanbul-lib-instrument/src/visitor.js b/packages/istanbul-lib-instrument/src/visitor.js
@@ -339,16 +339,16 @@ function blockProp(prop) {
     };
 }
 
-function makeParenthesizedExpression(path) {
-  var T = this.types;
-  if (path.node) {
-    path.replaceWith(T.parenthesizedExpression(path.node));
-  }
+function makeParenthesizedExpressionForNonIdentifier(path) {
+    var T = this.types;
+    if (path.node && !path.isIdentifier()) {
+        path.replaceWith(T.parenthesizedExpression(path.node));
+    }
 }
 
 function parenthesizedExpressionProp(prop) {
     return function (path) {
-        makeParenthesizedExpression.call(this, path.get(prop));
+        makeParenthesizedExpressionForNonIdentifier.call(this, path.get(prop));
     };
 }
 

diff --git a/packages/istanbul-lib-instrument/test/varia.test.js b/packages/istanbul-lib-instrument/test/varia.test.js
@@ -142,4 +142,12 @@ describe('varia', function () {
         code = v.getGeneratedCode();
         assert.ok(code.match(/cov_(.+);export class App extends/));
     });
+
+    it('does not add extra parenthesis when superclass is an identifier', function () {
+        var v = verifier.create('class App extends Component {};', { generateOnly: true }),
+            code;
+        assert.ok(!v.err);
+        code = v.getGeneratedCode();
+        assert.ok(code.match(/cov_(.+);class App extends Component/));
+    });
 });