fix: changed column header from "Uncovered Lines" to "Uncovered Line …

…#s" (#138)
istanbuljs · Feb 13, 2018 · 7ba7760 · 7ba7760
1 parent 4cedf63
commit 7ba7760
Show file tree

Hide file tree

Showing 4 changed files with 5 additions and 5 deletions.
diff --git a/packages/istanbul-reports/lib/text/index.js b/packages/istanbul-reports/lib/text/index.js
@@ -5,7 +5,7 @@
 "use strict";
 
 var PCT_COLS = 9,
-    MISSING_COL = 15,
+    MISSING_COL = 18,
     TAB_SIZE = 1,
     DELIM = ' |',
     COL_DELIM = '-|';
@@ -108,7 +108,7 @@ function tableHeader(maxNameCols) {
     elements.push(formatPct('% Branch'));
     elements.push(formatPct('% Funcs'));
     elements.push(formatPct('% Lines'));
-    elements.push(formatPct('Uncovered Lines', MISSING_COL));
+    elements.push(formatPct('Uncovered Line #s', MISSING_COL));
     return elements.join(' |') + ' |';
 }
 

diff --git a/packages/istanbul-reports/test/fixtures/specs/100-line-100-branch.json b/packages/istanbul-reports/test/fixtures/specs/100-line-100-branch.json
@@ -1,6 +1,6 @@
 {
   "title": "handles 100% branch and line coverage",
-  "textReportExpected": "----------|----------|----------|----------|----------|----------------|\nFile      |  % Stmts | % Branch |  % Funcs |  % Lines |Uncovered Lines |\n----------|----------|----------|----------|----------|----------------|\n\u001b[32;1mAll files\u001b[0m |\u001b[32;1m      100\u001b[0m |\u001b[32;1m      100\u001b[0m |\u001b[32;1m      100\u001b[0m |\u001b[32;1m      100\u001b[0m |\u001b[33;1m               \u001b[0m |\n\u001b[32;1m index.js\u001b[0m |\u001b[32;1m      100\u001b[0m |\u001b[32;1m      100\u001b[0m |\u001b[32;1m      100\u001b[0m |\u001b[32;1m      100\u001b[0m |\u001b[33;1m               \u001b[0m |\n----------|----------|----------|----------|----------|----------------|\n",
+  "textReportExpected": "----------|----------|----------|----------|----------|-------------------|\nFile      |  % Stmts | % Branch |  % Funcs |  % Lines | Uncovered Line #s |\n----------|----------|----------|----------|----------|-------------------|\n\u001b[32;1mAll files\u001b[0m |\u001b[32;1m      100\u001b[0m |\u001b[32;1m      100\u001b[0m |\u001b[32;1m      100\u001b[0m |\u001b[32;1m      100\u001b[0m |\u001b[33;1m                  \u001b[0m |\n\u001b[32;1m index.js\u001b[0m |\u001b[32;1m      100\u001b[0m |\u001b[32;1m      100\u001b[0m |\u001b[32;1m      100\u001b[0m |\u001b[32;1m      100\u001b[0m |\u001b[33;1m                  \u001b[0m |\n----------|----------|----------|----------|----------|-------------------|\n",
   "map": {
     "/Users/benjamincoe/oss/test-exclude/index.js": {
       "path": "/Users/benjamincoe/oss/test-exclude/index.js",

diff --git a/packages/istanbul-reports/test/fixtures/specs/100-line-missing-branch.json b/packages/istanbul-reports/test/fixtures/specs/100-line-missing-branch.json
@@ -1,6 +1,6 @@
 {
   "title": "100% line coverage, missing branch coverage",
-  "textReportExpected": "----------|----------|----------|----------|----------|----------------|\nFile      |  % Stmts | % Branch |  % Funcs |  % Lines |Uncovered Lines |\n----------|----------|----------|----------|----------|----------------|\n\u001b[32;1mAll files\u001b[0m |\u001b[32;1m      100\u001b[0m |\u001b[32;1m    95.35\u001b[0m |\u001b[32;1m      100\u001b[0m |\u001b[32;1m      100\u001b[0m |\u001b[33;1m               \u001b[0m |\n\u001b[32;1m index.js\u001b[0m |\u001b[32;1m      100\u001b[0m |\u001b[32;1m    95.35\u001b[0m |\u001b[32;1m      100\u001b[0m |\u001b[32;1m      100\u001b[0m |\u001b[33;1m          21,29\u001b[0m |\n----------|----------|----------|----------|----------|----------------|\n",
+  "textReportExpected": "----------|----------|----------|----------|----------|-------------------|\nFile      |  % Stmts | % Branch |  % Funcs |  % Lines | Uncovered Line #s |\n----------|----------|----------|----------|----------|-------------------|\n\u001b[32;1mAll files\u001b[0m |\u001b[32;1m      100\u001b[0m |\u001b[32;1m    95.35\u001b[0m |\u001b[32;1m      100\u001b[0m |\u001b[32;1m      100\u001b[0m |\u001b[33;1m                  \u001b[0m |\n\u001b[32;1m index.js\u001b[0m |\u001b[32;1m      100\u001b[0m |\u001b[32;1m    95.35\u001b[0m |\u001b[32;1m      100\u001b[0m |\u001b[32;1m      100\u001b[0m |\u001b[33;1m             21,29\u001b[0m |\n----------|----------|----------|----------|----------|-------------------|\n",
   "map": {
     "/Users/benjamincoe/oss/test-exclude/index.js": {
       "path": "/Users/benjamincoe/oss/test-exclude/index.js",

diff --git a/packages/istanbul-reports/test/fixtures/specs/missing-line-missing-branch.json b/packages/istanbul-reports/test/fixtures/specs/missing-line-missing-branch.json
@@ -1,6 +1,6 @@
 {
   "title": "missing line and branch coverage",
-  "textReportExpected": "----------|----------|----------|----------|----------|----------------|\nFile      |  % Stmts | % Branch |  % Funcs |  % Lines |Uncovered Lines |\n----------|----------|----------|----------|----------|----------------|\n\u001b[32;1mAll files\u001b[0m |\u001b[32;1m    98.04\u001b[0m |\u001b[32;1m    95.35\u001b[0m |\u001b[32;1m    88.89\u001b[0m |\u001b[32;1m    97.87\u001b[0m |\u001b[31;1m               \u001b[0m |\n\u001b[32;1m index.js\u001b[0m |\u001b[32;1m    98.04\u001b[0m |\u001b[32;1m    95.35\u001b[0m |\u001b[32;1m    88.89\u001b[0m |\u001b[32;1m    97.87\u001b[0m |\u001b[31;1m              9\u001b[0m |\n----------|----------|----------|----------|----------|----------------|\n",
+  "textReportExpected": "----------|----------|----------|----------|----------|-------------------|\nFile      |  % Stmts | % Branch |  % Funcs |  % Lines | Uncovered Line #s |\n----------|----------|----------|----------|----------|-------------------|\n\u001b[32;1mAll files\u001b[0m |\u001b[32;1m    98.04\u001b[0m |\u001b[32;1m    95.35\u001b[0m |\u001b[32;1m    88.89\u001b[0m |\u001b[32;1m    97.87\u001b[0m |\u001b[31;1m                  \u001b[0m |\n\u001b[32;1m index.js\u001b[0m |\u001b[32;1m    98.04\u001b[0m |\u001b[32;1m    95.35\u001b[0m |\u001b[32;1m    88.89\u001b[0m |\u001b[32;1m    97.87\u001b[0m |\u001b[31;1m                 9\u001b[0m |\n----------|----------|----------|----------|----------|-------------------|\n",
   "map": {
     "/Users/benjamincoe/oss/test-exclude/index.js": {
       "path": "/Users/benjamincoe/oss/test-exclude/index.js",