fix: address issue with class instrumentation (#111)

istanbuljs · Oct 22, 2017 · cbd1c14 · cbd1c14
1 parent 5e51254
commit cbd1c14
Show file tree

Hide file tree

Showing 3 changed files with 14 additions and 3 deletions.
diff --git a/packages/istanbul-lib-instrument/src/visitor.js b/packages/istanbul-lib-instrument/src/visitor.js
@@ -436,7 +436,7 @@ const codeVisitor = {
     AssignmentPattern: entries(coverAssignmentPattern),
     BlockStatement: entries(), // ignore processing only
     ClassMethod: entries(coverFunction),
-    ClassDeclaration: entries(parenthesizedExpressionProp('superClass'), coverStatement),
+    ClassDeclaration: entries(parenthesizedExpressionProp('superClass')),
     ExpressionStatement: entries(coverStatement),
     BreakStatement: entries(coverStatement),
     ContinueStatement: entries(coverStatement),

diff --git a/packages/istanbul-lib-instrument/test/specs/classes.yaml b/packages/istanbul-lib-instrument/test/specs/classes.yaml
@@ -20,7 +20,7 @@ code: |
 tests:
   - name: properly instruments code
     out: 'MyClass'
-    lines: {'1': 1, '2': 1}
+    lines: {'2': 1}
     functions: {}
-    statements: {'0': 1, '1': 1}
+    statements: {'0': 1}
     branches: {'0': [1, 0]}
diff --git a/packages/istanbul-lib-instrument/test/varia.test.js b/packages/istanbul-lib-instrument/test/varia.test.js
@@ -131,4 +131,15 @@ describe('varia', function () {
             assert.ok(!generated);
         });
     });
+
+    // see: https://github.com/istanbuljs/istanbuljs/issues/110
+    // TODO: it feels like we should be inserting line counters
+    // for class exports and class declarations.
+    it('properly exports named classes', function () {
+        var v = verifier.create('export class App extends Component {};', { generateOnly: true }, { esModules: true }),
+            code;
+        assert.ok(!v.err);
+        code = v.getGeneratedCode();
+        assert.ok(code.match(/cov_(.+);export class App extends/));
+    });
 });