chore: fix coverage results for all packages #11
Conversation
also address issue with istanbul-api package, hopefully
| "exclude": [ | ||
| "**/test/**", | ||
| "**/dist/**", | ||
| "**/bin/**" |
There was a problem hiding this comment.
TBPH I'm not a huge fan of this because it seems brittle (i.e. what if we hypothetically wanted to cover something in a dist/ folder?) but I think the compromise works because of the use case. Let me know what you all think :)
| ], | ||
| "reporter": [ | ||
| "text", | ||
| "lcov" |
There was a problem hiding this comment.
Added this for a local verification. I'm not overly attached to it, but text and lcov are usually the reporters I have on every project... but I am open to removing it for the sake of performance or some other valid reason.
JaKXz
force-pushed
the
fix/coverage-test-run
branch
from
011179c
to
c2a436d
Compare
|
@JaKXz if we add the yarn.lock can I still use npm? |
|
@bcoe I believe so, but I can remove it in case. I meant to use it in conjunction with the new functionality in: https://github.com/lerna/lerna/releases/tag/v2.0.0-beta.38 Up to you! :) |
also address issue with istanbul-api package, hopefully.