Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

More accurate overall coverage, less configuration #17

Merged
merged 3 commits into from
Mar 22, 2017

Conversation

JaKXz
Copy link
Member

@JaKXz JaKXz commented Mar 21, 2017

No description provided.

@JaKXz JaKXz requested a review from bcoe March 21, 2017 07:29
@coveralls
Copy link

Coverage Status

Coverage decreased (-4.1%) to 89.972% when pulling 14f94cd on JaKXz:chore/mocha-cleanup into 91191f3 on istanbuljs:master.

@JaKXz
Copy link
Member Author

JaKXz commented Mar 21, 2017

@bcoe My guess (say, 50% confidence) at what got things working in #11 for istanbul-api was just fixing configuration like this. I don't think mocha takes arguments after the -- like npm does.

@bcoe
Copy link
Member

bcoe commented Mar 22, 2017

@JaKXz this is looking good to land?

@JaKXz JaKXz merged commit 24919e8 into istanbuljs:master Mar 22, 2017
@JaKXz JaKXz deleted the chore/mocha-cleanup branch March 22, 2017 16:57
arnabsen pushed a commit to arnabsen/istanbuljs that referenced this pull request Feb 20, 2024
arnabsen pushed a commit to arnabsen/istanbuljs that referenced this pull request Feb 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants