html reporter not working

[Stupidism]

fs.js:951
  return binding.readdir(pathModule._makeLong(path), options.encoding);
                 ^

Error: ENOENT: no such file or directory, scandir 'xxxx/node_modules/nyc/node_modules/istanbul-reports/lib/html/assets'
    at Error (native)
    at Object.fs.readdirSync (fs.js:951:18)

[bcoe]

@Stupidism could you share a project (or a branch of a project) that is exhibiting this issue?

I haven't been able to reproduce on my own projects, which makes me think there must ben an edge-case that's triggering this behavior.

[Stupidism]

After reinstall nyc, it's gone in my project. It must be an installation error.

[Stupidism]

It happens again, here is my detailed tests:
I have a demo repo, but it can't reproduce this problem.
The bug only happens in my private repo.
After yarn clean it can be reproduced now !

Problem

There's no assets directory under path node_modules/istanbul-reports/lib/html/, after nyc is installed by yarn
I even tried yarn add --dev istanbul-reports directly in two repos. Results are different.

Steps to reproduce

git clone git@github.com:Stupidism/react-starter-kit.git -b feat/test-coverage
cd react-starter-kit
yarn install 

# First time, it should be working
yarn run coverage 

yarn remove nyc
yarn clean
yarn add --dev nyc

# This time, it breaks
yarn run coverage 

Temp solution

run rm -r node_modules/nyc; npm i nyc after yarn install

commands(Not important anymore)

• A: npm run test:cover
• B-G(global): nyc report --reporter=html
• B-L(local): ./node_modules/.bin/nyc report --reporter=html
• C(npm scripts): A && B-G

install tool	npm	yarn
run A and then B-G	working	working
run A and then B-L	working	working
run A && B-G	working	working
run A && B-L	working	error
run C (same as above)	working	error

[Stupidism]

Not sure this is a problem with yarn or istanbul
Possible reasons:

1. yarn has a bug
2. istanbul used some not-fullly-supported-by-yarn hook of npm.

[Stupidism]

@bcoe updates

[bcoe]

@Stupidism it sounds like this was an issue with yarn, that may have been resolved; mind testing things out with the latest version?

[bcoe]

@Stupidism I dug into this problem a bit further for you, the problem is the order of the rewire and istanbul plugin:

https://github.com/speedskater/babel-plugin-rewire#istanbul

If you swap the order of istanbul, and rewire in @JaKXz's example configuration, things should start working for you.

[Stupidism]

Not fixed yet! @bcoe

[bcoe]

@Stupidism I've tested @JaKXz's branch of your repo; if you switch the order of rewire and istanbul things should start working for you.

[Stupidism]

Have you tried these three cmds?

yarn remove nyc
yarn clean
yarn add --dev nyc

[bcoe]

@Stupidism no, but it sounded like there was a known issue with yarn deleting a required folder that was fixed in newer versions; @JaKXz can you speak to this?

[Stupidism]

Yeah, I guess it's a bug caused by yarn. I will watch that thread in yarn repo