Error: Attempt to close tag classes when packages was the one open #384

nstepien · 2019-05-02T14:34:39Z

My jest tests have started reporting this error today, as it's failing to generate a valid coverage report.

The report xml file ends with just this:

I believe this started happening following the most recent update.

nstepien · 2019-05-02T14:42:07Z

@coderica @coreyfarrell
It looks like df6e994 is the only commit that could've introduced this regression.
Please let me know if you need more information on my setup, it's a rather basic ts-jest config otherwise.

coreyfarrell · 2019-05-02T14:48:14Z

@MayhemYDG I have reset latest istanbul-reports to 2.2.4. If you delete your package-lock.json or yarn.lock and reinstall you should get the prior version. It would be helpful if we could get a test added to istanbul-reports demonstrating this failure so we can protect against this happening again in the future. Please do not close this issue as it hasn't been fixed, just suppressed.

@coderica this happened as a result of #382. For now I have not reverted the patch from git but I have reverted the latest on npm to the version without your patch.

I'll do what I can to help resolve this situation but I have nearly zero knowledge of cobertura.

nstepien · 2019-05-02T14:59:10Z

@coreyfarrell

It looks like @latest is still 2.2.5. I cleared my lockfile, my node_modules, even cleared the npm cache, and I'm still getting 2.2.5.

coreyfarrell · 2019-05-02T15:09:12Z

@MayhemYDG that's not what I'm seeing from npm info istanbul-reports or from https://www.npmjs.com/package/istanbul-reports. I suspect npmjs has distributed servers and you are hitting a server that has not yet seen my change.

nstepien · 2019-05-02T15:16:40Z

@coreyfarrell

Ah, you are correct, but I just figured out I'm still installing 2.2.5 because istanbul-api requires it.
679fc64#diff-69d6f06913bafe7128bf6ba176b2ecd2
It's the only package in my lockfile using it:

    "istanbul-api": {
      "version": "2.1.7",
      "resolved": "https://registry.npmjs.org/istanbul-api/-/istanbul-api-2.1.7.tgz",
      "integrity": "sha512-LYTOa2UrYFyJ/aSczZi/6lBykVMjCCvUmT64gOe+jPZFy4w6FYfPGqFT2IiQ2BxVHHDOvCD7qrIXb0EOh4uGWw==",
      "dev": true,
      "requires": {
        "async": "^2.6.2",
        "compare-versions": "^3.4.0",
        "fileset": "^2.0.3",
        "istanbul-lib-coverage": "^2.0.5",
        "istanbul-lib-hook": "^2.0.7",
        "istanbul-lib-instrument": "^3.3.0",
        "istanbul-lib-report": "^2.0.8",
        "istanbul-lib-source-maps": "^3.0.6",
        "istanbul-reports": "^2.2.5",
        "js-yaml": "^3.13.1",
        "make-dir": "^2.1.0",
        "minimatch": "^3.0.4",
        "once": "^1.4.0"
      }
    },

coreyfarrell · 2019-05-02T15:19:56Z

Ahh sorry I missed that. I've just set istanbul-api@2.1.6 as latest. Could take a bit before your local npm servers see this change.

nstepien · 2019-05-02T15:25:35Z

@coreyfarrell yup, it's all good now, thank you very much.

coderica · 2019-05-02T16:14:43Z

@MayhemYDG Sorry for the bug. I tested my change on my project but I guess I should have also tested on one that was already generating a properly formatted report.

Is there any way you can reproduce this in a test app I can use to investigate the issue?

JaKXz · 2019-05-02T16:17:00Z

It would be good to write some kind of snapshot test to make sure we can have the correct output produced in the cobertura reporter

coderica · 2019-05-02T16:49:02Z

yes, it sounds like we need a couple, for both this scenario and the one in #66

coreyfarrell · 2019-05-03T10:43:32Z

@coderica I had to revert #382 via #385 to make sure the regression isn't accidentally released again. Moving forward I agree with @JaKXz, we need expanded testing with any changes to this report. I'm hoping you and @MayhemYDG can work together in some capacity to figure out a fix which serves both of your needs.

nstepien · 2019-05-04T15:31:40Z

Okay here's a reduced test case:

`package.json`

{
  "scripts": {
    "test": "jest"
  },
  "devDependencies": {
    "istanbul-reports": "^2.2.5",
    "jest": "^24.7.1"
  },
  "jest": {
    "collectCoverage": true,
    "coverageReporters": [
      "cobertura"
    ]
  }
}

`module.test.js`

describe('reduced test case', () => {
  it('should generate a valid coverage report', () => {
    expect(false).toBe(true);
  })
});

Steps to reproduce:

npm i
npm t

You should then see something like

        Failed to write coverage reports:
        ERROR: Error: Attempt to close tag classes when packages was the one open
        STACK: Error: Attempt to close tag classes when packages was the one open
    at XMLWriter.closeTag (C:\istanbul\node_modules\istanbul-lib-report\lib\xml-writer.js:57:15)
    at CoberturaReport.onSummaryEnd (C:\istanbul\node_modules\istanbul-reports\lib\cobertura\index.js:73:14)
    at Visitor.<computed> [as onSummaryEnd] (C:\istanbul\node_modules\istanbul-lib-report\lib\tree.js:34:30)
    at ReportNode.Node.visit (C:\istanbul\node_modules\istanbul-lib-report\lib\tree.js:122:17)
    at Tree.visit (C:\istanbul\node_modules\istanbul-lib-report\lib\tree.js:150:20)
    at C:\istanbul\node_modules\istanbul-api\lib\reporter.js:94:18
    at Array.forEach (<anonymous>)
    at Reporter.write (C:\istanbul\node_modules\istanbul-api\lib\reporter.js:92:35)
    at C:\istanbul\node_modules\@jest\reporters\build\coverage_reporter.js:235:18
    at Generator.next (<anonymous>)

If you don't specify istanbul-reports version 2.2.5 in package.json, the coverage report won't fail.
If you make the test pass, the coverage report won't fail, although I've seen it fail will all tests passing before.

bcoe · 2019-05-06T02:51:48Z

@coderica nothing to be sorry about, the problem was lack of test coverage on our part (ironically).

None of the core Istanbul maintainers use cobertura, so we're not the best in the world at landing patches for it. Excited to work with you to re-land the patch 👍

KevinGrandon · 2019-05-14T19:51:35Z

Any chance at publishing istanbul-api@2.1.8 either with a revert or a fix? Starting to see many folks have failures with cobertura coverage reporting failures.

coreyfarrell · 2019-05-15T08:01:42Z

I've republished istanbul-reports@2.2.4 as 2.2.6 so this should no longer be an issue. You may have to refresh your package-lock.json or yarn.lock.

jesussobrino · 2019-05-15T09:06:42Z

I've republished istanbul-reports@2.2.4 as 2.2.6 so this should no longer be an issue. You may have to refresh your package-lock.json or yarn.lock.

I've just tried, and I still have the same issue.

coreyfarrell · 2019-05-15T09:11:01Z

I've just tried, and I still have the same issue.

Going to need more information than this. What does npm ls istanbul-reports say?

jesussobrino · 2019-05-15T09:39:15Z

I've just tried, and I still have the same issue.

Going to need more information than this. What does npm ls istanbul-reports say?

npm ls istanbul-reports says:

├── istanbul-reports@2.2.6 
└─┬ karma-coverage-istanbul-reporter@2.0.5
  └─┬ istanbul-api@2.1.7
    └── istanbul-reports@2.2.6  deduped

And now it's working like a charm. My previous problem was because I was using istanbul-reports@2.2.4. Sorry, but I didn't understand you properly :)

Anyway, thanks a lot!

coreyfarrell · 2019-05-23T12:53:36Z

@MayhemYDG @coderica PR #409 fails (throws) if run against istanbul-report@2.2.5, passes against current master. Actual cobertura output is not tested.

pcoop mentioned this issue May 2, 2019

Better output from 'generate bundle' IBM/zowe-cli-cics-deploy-plugin#119

Merged

bcoe mentioned this issue May 6, 2019

fix(istanbul-reports): Remove isRoot check causing incorrect report formatting (#66). #382

Merged

coreyfarrell added a commit that referenced this issue May 23, 2019

chore: Add regression test for #384 (#409)

7370ab3

nstepien closed this as completed May 8, 2020

Swiftwork mentioned this issue Oct 9, 2020

fix cobertura report #571

Merged

bradtaniguchi mentioned this issue Feb 21, 2023

Error generating clover report #715

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Error: Attempt to close tag classes when packages was the one open #384

Error: Attempt to close tag classes when packages was the one open #384

nstepien commented May 2, 2019 •

edited

nstepien commented May 2, 2019

coreyfarrell commented May 2, 2019

nstepien commented May 2, 2019 •

edited

coreyfarrell commented May 2, 2019

nstepien commented May 2, 2019

coreyfarrell commented May 2, 2019

nstepien commented May 2, 2019

coderica commented May 2, 2019

JaKXz commented May 2, 2019

coderica commented May 2, 2019

coreyfarrell commented May 3, 2019

nstepien commented May 4, 2019

bcoe commented May 6, 2019

KevinGrandon commented May 14, 2019

coreyfarrell commented May 15, 2019

jesussobrino commented May 15, 2019

coreyfarrell commented May 15, 2019

jesussobrino commented May 15, 2019

coreyfarrell commented May 23, 2019

Error: Attempt to close tag classes when packages was the one open #384

Error: Attempt to close tag classes when packages was the one open #384

Comments

nstepien commented May 2, 2019 • edited

nstepien commented May 2, 2019

coreyfarrell commented May 2, 2019

nstepien commented May 2, 2019 • edited

coreyfarrell commented May 2, 2019

nstepien commented May 2, 2019

coreyfarrell commented May 2, 2019

nstepien commented May 2, 2019

coderica commented May 2, 2019

JaKXz commented May 2, 2019

coderica commented May 2, 2019

coreyfarrell commented May 3, 2019

nstepien commented May 4, 2019

package.json

module.test.js

bcoe commented May 6, 2019

KevinGrandon commented May 14, 2019

coreyfarrell commented May 15, 2019

jesussobrino commented May 15, 2019

coreyfarrell commented May 15, 2019

jesussobrino commented May 15, 2019

coreyfarrell commented May 23, 2019

nstepien commented May 2, 2019 •

edited

nstepien commented May 2, 2019 •

edited

`package.json`

`module.test.js`