Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: correct variable name in source-map transform #257

Merged
merged 1 commit into from
Dec 24, 2018
Merged

fix: correct variable name in source-map transform #257

merged 1 commit into from
Dec 24, 2018

Conversation

SimenB
Copy link
Member

@SimenB SimenB commented Dec 19, 2018

A linter should probably have caught this

@SimenB
Copy link
Member Author

SimenB commented Dec 19, 2018

/cc @bcoe fixes the error in Jest

@thymikee
Copy link

A linter would have caught issues like this one 😅

@thymikee
Copy link

@SimenB maybe worth adding a test that traverse this path? Not sure how hard that's gonna be though

@SimenB
Copy link
Member Author

SimenB commented Dec 19, 2018

Sourcemaps are such a magical black box to me still, even after I spent quite a few hours trying to grasp the basics of it :P Not sure which case triggers this branch

@thymikee
Copy link

Haha, that's exactly why I added "Not sure how hard that's gonna be though" :D

@bcoe
Copy link
Member

bcoe commented Dec 19, 2018

@loganfsmyth any thoughts on a way to exercise this line? @SimenB if you saw fit to plop in a linter (which I think we should have setup on the other packages perhaps?) it would be amazing.

@SimenB
Copy link
Member Author

SimenB commented Dec 20, 2018

Can this be merged and released in the meantime, the current prerelease is pretty broken due to this 🙂

I can send a PR for some linting, sure

@SimenB SimenB mentioned this pull request Dec 20, 2018
@bcoe
Copy link
Member

bcoe commented Dec 24, 2018

@SimenB 👋 working on landing it now.

@bcoe bcoe merged commit de9c921 into istanbuljs:master Dec 24, 2018
@SimenB SimenB deleted the patch-1 branch December 25, 2018 10:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants