Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Honor istanbul ignore next hints placed before export statement. #298

Merged
merged 1 commit into from
Feb 18, 2019
Merged

fix: Honor istanbul ignore next hints placed before export statement. #298

merged 1 commit into from
Feb 18, 2019

Conversation

coreyfarrell
Copy link
Member

Fixes #297

@coreyfarrell
Copy link
Member Author

prettier 😠

@coreyfarrell coreyfarrell merged commit f24795d into istanbuljs:master Feb 18, 2019
@coreyfarrell coreyfarrell deleted the ignore-next-export branch February 18, 2019 22:27
@JaKXz
Copy link
Member

JaKXz commented Feb 18, 2019

@coreyfarrell protip: I use npx pretty-quick --staged when committing.

@coreyfarrell
Copy link
Member Author

@JaKXz normally I wouldn't do a change without running npm test which would run eslint. In this case it took me a few tries to get the test working so I ran tests against istanbul-lib-instrument only - which bypassed the posttest in the root package.json.

Really my frustration with prettier is mostly just personal preference, complying with prettier style is difficult for me.

@JaKXz
Copy link
Member

JaKXz commented Feb 18, 2019

I've had this discussion at [way too much] length with colleagues, so I mean this with the best possible intent: I try not to worry too much about "complying" with the style. I just make my changes, stage them, and let pretty-quick take care of compliance.

FWIW it was extremely liberating once I thought about it this way, I too had similar apprehensions at first.

@coreyfarrell
Copy link
Member Author

As long as I remember to run the full npm test instead of short-cutting it eslint tells me what I did wrong then I just run npx eslint . --fix (the test failure tells me to do this so this is what I remember).

I don't really have apprehensions about prettier, it's just annoying to me. Personally I don't find that prettier produces more readable code, I especially dislike the rules about line length.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants