feat: set medium colour to yellow #306
Conversation
As discussed in gotwarlost/istanbul#542, this PR brings back the yellow colour for medium. There are many good points raised in that PR, and this PR, aims to replicate address those concerns for this repo.
| .medium .chart { border:1px solid #666; } | ||
| .medium .cover-fill { background: #666; } | ||
| /* dark yellow (gold) */ | ||
| .status-line.medium, .medium .cover-fill { background: #f9cd0b; } |
There was a problem hiding this comment.
This seems to me like a 'bright yellow' rather than dark yellow. How would you feel about #f1c50b instead (for .medium .chart as well)?
|
I'm fine with any yellow colour. The colours I pulled were from the origin PR. |
There was a problem hiding this comment.
🤷♂️ I too am fine with any shade. My only ask would be to install https://colororacle.org/ and test it under different conditions.
|
I just tried this out (nice utility btw). I think this PR is an improvement for deuteranopia (listed as common). Deuteranopia seems to make the current background red (for low coverage) appear as grey (the same as middle coverage). Unfortunately green (high coverage) appears yellowish, but it appears as a different yellow than what we use for middle coverage. New color scheme: With deuteranopia: Original with deuteranopia: So I think this is an improvement to switch medium coverage away from grey. I think it's less harmful for medium coverage to nearly look like high coverage than it is for low coverage to look exactly like medium coverage. |
|
Thanks @coreyfarrell! I am good to merge if you are |
|
Thanks for the contribution @whitneyit! |
|
This was good news to wake up to! Cheers all |
As discussed in gotwarlost/istanbul#542, this PR brings back the yellow colour for medium. There are many good points raised in that PR, and this PR, aims to replicate address those concerns for this repo.
As discussed in gotwarlost/istanbul#542, this
PR brings back the yellow colour for medium.
There are many good points raised in that PR, and this PR, aims to
replicate address those concerns for this repo.