feat: Use @istanbuljs/schema to pull defaults #485
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes #460 BREAKING CHANGE: The defaults for `autoWrap`, `preserveComments`, `esModules` and `produceSourceMap` are now true. This applies only to the stand-alone instrumenter, the visitor does not use these options. BREAKING CHANGE: The `flow` and `jsx` parser plugins are no longer enabled by default. This applies only to the stand-alone instrumenter, the visitor does not use this option. BREAKING CHANGE: The `plugins` option of the stand-alone instrumenter has been renamed to `parserPlugins` to match nyc.
vivek-freshworks
pushed a commit
to freshworks/istanbuljs
that referenced
this pull request
Oct 16, 2023
Fixes istanbuljs#460 BREAKING CHANGE: The defaults for `autoWrap`, `preserveComments`, `esModules` and `produceSourceMap` are now true. This applies only to the stand-alone instrumenter, the visitor does not use these options. BREAKING CHANGE: The `flow` and `jsx` parser plugins are no longer enabled by default. This applies only to the stand-alone instrumenter, the visitor does not use this option. BREAKING CHANGE: The `plugins` option of the stand-alone instrumenter has been renamed to `parserPlugins` to match nyc.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #460
BREAKING CHANGE: The defaults for
autoWrap,preserveComments,esModulesandproduceSourceMapare now true. This applies only tothe stand-alone instrumenter, the visitor does not use these options.
BREAKING CHANGE: The
flowandjsxparser plugins are no longerenabled by default. This applies only to the stand-alone instrumenter,
the visitor does not use this option.
BREAKING CHANGE: The
pluginsoption of the stand-alone instrumenterhas been renamed to
parserPluginsto match nyc.The removal of
flowandjsxdefault parser plugins will be a breaking change in nyc@15. All other default changes actually cause the built-in instrumenter defaults to match those currently used by nyc. Listed as breaking changes here on the off chance that this effects outside users. None of these breaking changes will have any effect onbabel-plugin-istanbul.