fix: hoist statement counter for class variables #60
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
With `const foo = class {}`, `foo.name` should be `'foo'`. Without this
commit the instrumentation causes `foo.name` to be an empty string.
Hoist the statement counter just like it's done for function and arrow
expressions. Fixes #59.
|
@novemberborn great work 👍 thanks for diving into this. |
|
@novemberborn this is now landed and available in |
|
@bcoe going by novemberborn/function-name-support#2 the failing AVA tests are now passing, which implies the instrumentation is no longer interfering. I haven't had a chance yet to actually update the test code though. |
|
Works great @bcoe. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With
const foo = class {},foo.nameshould be'foo'. Without this commit the instrumentation causesfoo.nameto be an empty string.Hoist the statement counter just like it's done for function and arrow expressions. Fixes #59.