coverage folder is not being excluded on nyc@10.2.0

[astorije]

Expected Behavior

coverage/ folder being excluded even when not present from the exclude list.

Observed Behavior

See comment made at #502 (comment).

Bonus Points! Code (or Repository) that Reproduces Issue

Look at https://github.com/thelounge/lounge/blob/master/.nycrc (that gets run with npm run coverage). We removed coverage/ from the exclude list of The Lounge here but I have just noticed that it is not ignored anymore.

Forensic Information

Operating System: macOS 10.11.6
Environment Information: Result of sh -c 'node --version; npm --version; npm ls'

[bcoe]

@astorije I believe the underlying issue might be that the coverage folder looks to be nested under the lounge folder -- this is a bit strange (I think I might only add the top level ./coverage to test-exclude).

Should we be excluding it at all levels?

[astorije]

I'm not sure what you mean by that, @bcoe.

$ npm run coverage
...
$ ls -la
...
drwxr-xr-x    5 jeremie  staff   170B May 13 20:47 .nyc_output/
-rw-r--r--    1 jeremie  staff   200B Apr 28 14:23 .nycrc
...
drwxr-xr-x    5 jeremie  staff   170B Apr 17 23:29 coverage/
...

The lounge folder on my screenshot is the top-level folder, i.e. what you get when you run git clone https://github.com/thelounge/lounge.

[bcoe]

@astorije are you running an lcov report in the above example? I would expect the top level to look more like this:

I ran the above report with JavaScript in the coverage folder, and it doesn't show up in the report -- it seems almost as though nyc thinks tests are being run one level above the root folder is all I can think of.

[astorije]

I'm only running npm run coverage, which in turn runs nyc mocha with this .nycrc file (where there is the lcov reporter indeed).
Sorry I'm not helping much, we don't make an extensive use of nyc/istanbul in the project yet so experience is limited.

[bcoe]

@astorije took the time to look into things a little bit for you, sorry for the slow reply.

If you add this to your exclude, **/coverage/**, then things should work as expected. The problem is that something in your testing configuration is changing the root folder, so that file paths are reported as lounge/coverage/foo.js rather than the expected coverage/foo.js -- not quite sure what's munging your file paths (nothing immediately jumped out at me in the project). But adding that additional exclude rule should at least work around the problem.