Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Modernize lib/source-maps.js #1175

Merged
merged 1 commit into from
Sep 24, 2019

Conversation

coreyfarrell
Copy link
Member

  • Convert to class
  • Prefer const over var
  • Use Object.entries()

This eliminates the last use of prototype based class declaration in nyc, git grep prototype only shows the one place where a test replaces one of the nyc methods.

* Convert to class
* Prefer const over var
* Use Object.entries()
@coveralls
Copy link

Coverage Status

Coverage decreased (-0.02%) to 98.482% when pulling 5be3e04 on coreyfarrell:modernize-source-maps into f645762 on istanbuljs:master.

@coreyfarrell
Copy link
Member Author

Not an actual drop in coverage, this removes coverable lines/statements from lib/source-maps.js, for example SourceMaps.prototype.cachedPath = function ... was previously a coverage hit.

@coreyfarrell coreyfarrell merged commit b59fc8f into istanbuljs:master Sep 24, 2019
@coreyfarrell coreyfarrell deleted the modernize-source-maps branch September 24, 2019 17:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants