Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update README.md #366

Merged
merged 3 commits into from
Aug 25, 2016
Merged

Update README.md #366

merged 3 commits into from
Aug 25, 2016

Conversation

matheusrocha89
Copy link
Contributor

Adding note that since version 8.0 the node_modules is no more excluded automatically

Adding note that since version 8.0 the node_modules is no more excluded automatically
@@ -185,6 +184,8 @@ directory:
}
}
```
> Note: Since version 8.0 the `node_modules` folder is not automatically excluded,
you need o explicit add in your exclude array
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

s/o/to

@coveralls
Copy link

coveralls commented Aug 24, 2016

Coverage Status

Changes Unknown when pulling 4aa40a3 on matheusrocha89:patch-1 into * on istanbuljs:master*.

@coveralls
Copy link

Coverage Status

Changes Unknown when pulling 5fb6c51 on matheusrocha89:patch-1 into * on istanbuljs:master*.

1 similar comment
@coveralls
Copy link

coveralls commented Aug 24, 2016

Coverage Status

Changes Unknown when pulling 5fb6c51 on matheusrocha89:patch-1 into * on istanbuljs:master*.

@@ -185,6 +184,8 @@ directory:
}
}
```
> Note: Since version 8.0 if you add a "exclude" array the `node_modules`
folder is not automatically excluded, you need to explicit add it to your exclude array
Copy link
Member

@bcoe bcoe Aug 24, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you will need to explicitly add it to your exclude array.

@bcoe
Copy link
Member

bcoe commented Aug 24, 2016

@matheusrocha89 one grammar nit, thanks for the contribution!

@coveralls
Copy link

coveralls commented Aug 25, 2016

Coverage Status

Changes Unknown when pulling 6bc86fb on matheusrocha89:patch-1 into * on istanbuljs:master*.

@bcoe bcoe merged commit 1189f3a into istanbuljs:master Aug 25, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants