Fix windows spawn #38
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Under Windows, the js file isn't executable.
Things like the name of the checkout or the path separators can change.
|
@rmg thanks, any thoughts as to why the coverage reports themselves ain't workin' on Windows? spawn-wrap related perhaps? |
|
@bcoe I spent a while digging through it but couldn't seem to get past this, but I was only looking at this module (I don't have a real Windows dev environment, so working with multiple repos was too annoying). I assume it is related to path separators being translated in some places and preserved in others. |
|
@rmg released in |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This doesn't fix the problem of coverage not working on Windows, and it isn't a complete fix to the general problem of running on Windows, but if tap is upgraded to a version of nyc with this fix applied it should at least stop crashing on Windows when
tap --coverageis run.It may even fix #26
/cc @sam-github @isaacs