Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add support for .nycrc #391

Merged
merged 1 commit into from
Sep 15, 2016
Merged

feat: add support for .nycrc #391

merged 1 commit into from
Sep 15, 2016

Conversation

bcoe
Copy link
Member

@bcoe bcoe commented Sep 13, 2016

now that we refactored configuration loading in #388, it was much easier to add support for a .nycrc file.

see #320

CC: @jeffijoe, @ChrisPearce

@bcoe
Copy link
Member Author

bcoe commented Sep 13, 2016

@jeffijoe, @ChrisPearce, @addaleax, @JaKXz

would greatly appreciate if you could give this a spin, about of exciting new features are about to go out the door on the next latest, but they shuffle around a lot of code. To try the candidate release:

npm cache clear; npm i nyc@next

@@ -152,4 +150,4 @@
"yargs",
"yargs-parser"
]
}
}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: you should install editorconfig

@jeffijoe
Copy link

@bcoe just tested on 2 projects, this appears to work perfectly! Thanks!

@bcoe bcoe merged commit 1c2349b into master Sep 15, 2016
@bcoe bcoe deleted the nycrc branch September 15, 2016 07:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants