Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

hook vm.runInContext #680

Merged
merged 4 commits into from
Oct 23, 2017
Merged

hook vm.runInContext #680

merged 4 commits into from
Oct 23, 2017

Conversation

pangrr
Copy link

@pangrr pangrr commented Sep 22, 2017

fix issue #85 along with this pull request to istanbuljs. The CI check on this pull request will fail because of dependency on the other pull request.

@pangrr
Copy link
Author

pangrr commented Oct 16, 2017

@bcoe Could you please merge this PR? Or nyc won't work with hookRunInContext.

@bcoe
Copy link
Member

bcoe commented Oct 23, 2017

@pangrr mind taking a look at the failing tests? Once we're green I'll happily merge this.

@coveralls
Copy link

coveralls commented Oct 23, 2017

Coverage Status

Changes Unknown when pulling 5612e2e on bloomberg:master into ** on istanbuljs:master**.

@pangrr
Copy link
Author

pangrr commented Oct 23, 2017

@bcoe here you go

@bcoe bcoe merged commit f04b7a9 into istanbuljs:master Oct 23, 2017
@bcoe
Copy link
Member

bcoe commented Oct 23, 2017

@pangrr give this a shot:

npm i nyc@next --save-dev

@pangrr
Copy link
Author

pangrr commented Oct 23, 2017

@bcoe looks good!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants