Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Recast forking with capture require #90

Conversation

jamestalmage
Copy link
Member

Well this was easy!

This is #89, with with one commit from cherry picked from #77 (unmodified, not even a conflict!).

If nothing else, it's confirmation our testing strategy is moving in the right direction.

Now that I have capture-require actually working with something beyond it's own test suite, I guess it is time to publish it for real.

@bcoe
Copy link
Member

bcoe commented Dec 12, 2015

@jamestalmage this answers my question on #77, great work -- excited to get some of this work merged, and to then concentrate on better Windows support.

@ariporad
Copy link

Thanks so much @jamestalmage!

@bcoe: Any idea when we might expect to see this merged?

@jamestalmage
Copy link
Member Author

#89 needs to get merged first.

(cherry picked from commit f9185aa)
@jamestalmage jamestalmage force-pushed the recast-forking-with-capture-require branch from c554384 to 4a337a9 Compare December 14, 2015 23:46
@jamestalmage jamestalmage changed the title WIP: Recast forking with capture require Recast forking with capture require Dec 14, 2015
jamestalmage added a commit that referenced this pull request Dec 14, 2015
…require

Use capture-require module.

Closes #79 
Closes #70
@jamestalmage jamestalmage merged commit 958e96c into istanbuljs:master Dec 14, 2015
@jamestalmage jamestalmage deleted the recast-forking-with-capture-require branch December 14, 2015 23:50
@jamestalmage jamestalmage mentioned this pull request Dec 14, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants