Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test-exclude: README issues #33

Closed
coreyfarrell opened this issue Mar 8, 2019 · 0 comments · Fixed by #39
Closed

test-exclude: README issues #33

coreyfarrell opened this issue Mar 8, 2019 · 0 comments · Fixed by #39

Comments

@coreyfarrell
Copy link
Member

  • The first argument of shouldInstrument needs to be an absolute filename.
  • Need to document excludeNodeModules: false as the preferred method of not excluding node_modules.
  • Overall need more complete API documentation. Can we use JS docs or something to generate documentation?
@coreyfarrell coreyfarrell transferred this issue from istanbuljs/istanbuljs Sep 30, 2019
coreyfarrell added a commit to coreyfarrell/test-exclude that referenced this issue Dec 6, 2019
@coreyfarrell
fix: Directly export class, document API.
84a7362 
BREAKING CHANGE: `test-exclude` now exports a class so it is necessary
to use `new TestExclude()` when creating an instance.

Fixes istanbuljs#33
@coreyfarrell coreyfarrell mentioned this issue Dec 6, 2019
Merged
coreyfarrell added a commit that referenced this issue Dec 7, 2019
@coreyfarrell
fix: Directly export class, document API. (#39)
3acc196 
BREAKING CHANGE: `test-exclude` now exports a class so it is necessary
to use `new TestExclude()` when creating an instance.

Fixes #33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: Directly export class, document API. coreyfarrell/test-exclude
1 participant
@coreyfarrell