New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: test with Node.js v12 instead of no longer maintained v11 #28

Closed

shinnn wants to merge 1 commit into master from node12

Collaborator

shinnn commented Jun 8, 2019

11.x is End-of-Life starting at the 2019-06-01. https://github.com/nodejs/Release/blob/c7be2c8908acd876a4393ff90c62100942ebba1b/README.md#end-of-life-releases


          chore: test with Node.js v12 instead of no longer maintained v11

675eaf1

coveralls commented Jun 8, 2019

Pull Request Test Coverage Report for Build 111

0 of 0 changed or added relevant lines in 0 files are covered.
27 unchanged lines in 1 file lost coverage.
Overall coverage decreased (-4.7%) to 91.554%

Files with Coverage Reduction	New Missed Lines	%
lib/v8-to-istanbul.js	27	85.34%

Totals
Change from base Build 109:	-4.7%
Covered Lines:	458
Relevant Lines:	498

💛 - Coveralls

Member

bcoe commented Jun 11, 2019

@shinnn slightly concerned by slight drop in coverage, any idea what the culprit is?

bcoe closed this

bcoe deleted the node12 branch

June 23, 2019 00:56

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment