Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix meshPort nil #200

Merged
merged 1 commit into from
Apr 8, 2022
Merged

Conversation

itsLucario
Copy link
Collaborator

Fix meshPort nil for canary rollout without weighted services

Signed-off-by: nbn01 <nandan_bn@intuit.com>
Copy link
Contributor

@aattuluri aattuluri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@itsLucario itsLucario merged commit b3183b6 into istio-ecosystem:master Apr 8, 2022
psikka1 pushed a commit to psikka1/admiral that referenced this pull request Jun 14, 2022
)

Signed-off-by: nbn01 <nandan_bn@intuit.com>

Co-authored-by: nbn01 <nandan_bn@intuit.com>
psikka1 pushed a commit to psikka1/admiral that referenced this pull request Jun 15, 2022
)

Signed-off-by: nbn01 <nandan_bn@intuit.com>

Co-authored-by: nbn01 <nandan_bn@intuit.com>
Signed-off-by: psikka1 <pankaj_sikka@intuit.com>
asushanthk pushed a commit that referenced this pull request Jul 21, 2022
Signed-off-by: nbn01 <nandan_bn@intuit.com>

Co-authored-by: nbn01 <nandan_bn@intuit.com>
Signed-off-by: sa <sushanth_a@intuit.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants