-
Notifications
You must be signed in to change notification settings - Fork 76
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Clean up cache upon k8s service deletes #201
Merged
aattuluri
merged 60 commits into
istio-ecosystem:master
from
aattuluri:Handle-k8s-service-deletes-and-switches-gracefully
Apr 8, 2022
Merged
Clean up cache upon k8s service deletes #201
aattuluri
merged 60 commits into
istio-ecosystem:master
from
aattuluri:Handle-k8s-service-deletes-and-switches-gracefully
Apr 8, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: aattuluri <anil_attuluri@intuit.com>
Signed-off-by: aattuluri <anil_attuluri@intuit.com>
Signed-off-by: aattuluri <anil_attuluri@intuit.com>
Signed-off-by: aattuluri <anil_attuluri@intuit.com>
This reverts commit a9fa409.
…mmit sha if neither i) or ii)
asushanthk
approved these changes
Apr 8, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
psikka1
pushed a commit
to psikka1/admiral
that referenced
this pull request
Jun 14, 2022
* Bootstrapping admiral * Add circle ci config * Fix the working directory for builds * Bootstrapping admiral Signed-off-by: aattuluri <anil_attuluri@intuit.com> * Add circle ci config Signed-off-by: aattuluri <anil_attuluri@intuit.com> * Fix the working directory for builds Signed-off-by: aattuluri <anil_attuluri@intuit.com> * Add build status badge. Signed-off-by: aattuluri <anil_attuluri@intuit.com> * Revert "Add build status badge." This reverts commit a9fa409. * Publish images: i) latest from master, ii) TAG if its set and iii) commit sha if neither i) or ii) * Do not do destructive updates during bootup time * Clean up cache on k8s service deletes
psikka1
pushed a commit
to psikka1/admiral
that referenced
this pull request
Jun 15, 2022
* Bootstrapping admiral * Add circle ci config * Fix the working directory for builds * Bootstrapping admiral Signed-off-by: aattuluri <anil_attuluri@intuit.com> * Add circle ci config Signed-off-by: aattuluri <anil_attuluri@intuit.com> * Fix the working directory for builds Signed-off-by: aattuluri <anil_attuluri@intuit.com> * Add build status badge. Signed-off-by: aattuluri <anil_attuluri@intuit.com> * Revert "Add build status badge." This reverts commit a9fa409. * Publish images: i) latest from master, ii) TAG if its set and iii) commit sha if neither i) or ii) * Do not do destructive updates during bootup time * Clean up cache on k8s service deletes Signed-off-by: psikka1 <pankaj_sikka@intuit.com>
asushanthk
pushed a commit
that referenced
this pull request
Jul 21, 2022
* Bootstrapping admiral * Add circle ci config * Fix the working directory for builds * Bootstrapping admiral Signed-off-by: aattuluri <anil_attuluri@intuit.com> * Add circle ci config Signed-off-by: aattuluri <anil_attuluri@intuit.com> * Fix the working directory for builds Signed-off-by: aattuluri <anil_attuluri@intuit.com> * Add build status badge. Signed-off-by: aattuluri <anil_attuluri@intuit.com> * Revert "Add build status badge." This reverts commit a9fa409. * Publish images: i) latest from master, ii) TAG if its set and iii) commit sha if neither i) or ii) * Do not do destructive updates during bootup time * Clean up cache on k8s service deletes Signed-off-by: sa <sushanth_a@intuit.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.