Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

exposed outlierDetection configuration through GTP #217

Conversation

shriramsharma
Copy link
Collaborator

@shriramsharma shriramsharma commented May 12, 2022

Fixes #104
Extended the GTP API to expose outlierDetection configuration.

Example GTP Config:

apiVersion: admiral.io/v1alpha1
kind: GlobalTrafficPolicy
metadata:
  name: gtp-failover-config
  namespace: sample
  annotations:
    admiral.io/env: stage
  labels:
    identity: greeting
spec:
  policy:
    - dnsPrefix: default # default is a keyword, alternatively you can use `env` (ex: stage)
      lbType: 1 #0 represents TOPOLOGY, 1 represents FAILOVER
      target:
        - region: us-west-2
          weight: 80
        - region: us-east-2
          weight: 20
      outlier_detection:
        base_ejection_time: 180
        consecutive_gateway_errors: 1000
        interval: 60

Copy link
Contributor

@psikka1 psikka1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

exposed outlierDetection configuration through GTP

Signed-off-by: Shriram Sharma <shriram_sharma@intuit.com>
@shriramsharma shriramsharma merged commit 059a0d5 into istio-ecosystem:master May 19, 2022
@shriramsharma shriramsharma deleted the expose_outlierdetection_104 branch May 19, 2022 23:01
psikka1 pushed a commit to psikka1/admiral that referenced this pull request Jun 15, 2022
exposed outlierDetection configuration through GTP

Signed-off-by: Shriram Sharma <shriram_sharma@intuit.com>
Signed-off-by: psikka1 <pankaj_sikka@intuit.com>
asushanthk pushed a commit that referenced this pull request Jul 21, 2022
exposed outlierDetection configuration through GTP

Signed-off-by: Shriram Sharma <shriram_sharma@intuit.com>
Signed-off-by: sa <sushanth_a@intuit.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Enhancement] Make OutlierDetection params configurable
3 participants