process gtps as soon they are applied #223
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
process gtps as soon they are applied Signed-off-by: Shriram Sharma <shriram_sharma@intuit.com>
ccfishk
reviewed
Jun 2, 2022
admiral/pkg/clusters/types.go
Outdated
| @@ -243,3 +247,19 @@ func HandleEventForDeployment(event admiral.EventType, obj *k8sAppsV1.Deployment | |||
| // Use the same function as added deployment function to update and put new service entry in place to replace old one | |||
| modifyServiceEntryForNewServiceOrPod(event, env, globalIdentifier, remoteRegistry) | |||
| } | |||
|
|
|||
| // HandleEventForGlobalTrafficPolicy processes all the events related to GTPs | |||
| func HandleEventForGlobalTrafficPolicy(event admiral.EventType, gtp *v1.GlobalTrafficPolicy, remoteRegistry *RemoteRegistry, clusterName string) { | |||
There was a problem hiding this comment.
Suggested change
| func HandleEventForGlobalTrafficPolicy(event admiral.EventType, gtp *v1.GlobalTrafficPolicy, remoteRegistry *RemoteRegistry, clusterName string) { | |
| func HandleEventForGlobalTrafficPolicy(event admiral.EventType, gtp *v1.GlobalTrafficPolicy, remoteRegistry *RemoteRegistry, clusterName string) error { |
There was a problem hiding this comment.
wouldn't an error for error case would help the function ?
ccfishk
approved these changes
Jun 2, 2022
nirvanagit
reviewed
Jun 2, 2022
admiral/pkg/clusters/types.go
Outdated
| @@ -243,3 +247,19 @@ func HandleEventForDeployment(event admiral.EventType, obj *k8sAppsV1.Deployment | |||
| // Use the same function as added deployment function to update and put new service entry in place to replace old one | |||
| modifyServiceEntryForNewServiceOrPod(event, env, globalIdentifier, remoteRegistry) | |||
| } | |||
|
|
|||
| // HandleEventForGlobalTrafficPolicy processes all the events related to GTPs | |||
| func HandleEventForGlobalTrafficPolicy(event admiral.EventType, gtp *v1.GlobalTrafficPolicy, remoteRegistry *RemoteRegistry, clusterName string) { | |||
There was a problem hiding this comment.
Can a few test cases be added for HandleEventForGlobalTrafficPolicy?
Signed-off-by: Shriram Sharma <shriram_sharma@intuit.com>
nirvanagit
reviewed
Jun 9, 2022
admiral/pkg/clusters/types.go
Outdated
| } | ||
|
|
||
| func (gtp *GlobalTrafficHandler) Updated(obj *v1.GlobalTrafficPolicy) { | ||
| log.Infof(LogFormat, "Updated", "globaltrafficpolicy", obj.Name, gtp.ClusterID, "received") | ||
| HandleEventForGlobalTrafficPolicy(admiral.Update, obj, gtp.RemoteRegistry, gtp.ClusterID) |
There was a problem hiding this comment.
Will an assignment of _ = HandleEventForGlobalTrafficPolicy(..) help to prevent warning from Github Actions?
Signed-off-by: Shriram Sharma <shriram_sharma@intuit.com>
Signed-off-by: Shriram Sharma <shriram_sharma@intuit.com>
Signed-off-by: Shriram Sharma <shriram_sharma@intuit.com>
nirvanagit
approved these changes
Jun 10, 2022
psikka1
pushed a commit
to psikka1/admiral
that referenced
this pull request
Jun 15, 2022
Signed-off-by: psikka1 <pankaj_sikka@intuit.com>
asushanthk
pushed a commit
that referenced
this pull request
Jul 21, 2022
Signed-off-by: sa <sushanth_a@intuit.com>
asushanthk
pushed a commit
that referenced
this pull request
Jul 21, 2022
Signed-off-by: sa <sushanth_a@intuit.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #221 process gtps as soon they are applied
Signed-off-by: Shriram Sharma shriram_sharma@intuit.com