Update CRD to use apiextensions.k8s.io/v1 #247
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…io/v1 Signed-off-by: Alex Mirkhaydarov <12385311+alexdotsh@users.noreply.github.com>
aattuluri
approved these changes
Jul 25, 2022
|
@alexdotsh Thanks for the PR. This looks good, would you mind auditing other resources under the admiral/install directory for other resources that would have been deprecated in k8s 1.22. |
|
@aattuluri those were the only ones I manage to find that was deprecated. I think the rest are fine |
|
@alexdotsh , can you please resolve the CI failures? Thanks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As of K8s 1.22 the apiextensions.k8s.io/v1beta1 is deprecated and longer used, which causing issues to install on K8s running on version 1.22
This is PR is to address and update to use the newer
apiextensions.k8s.io/v1The apiextensions.k8s.io/v1 API version, available since v1.16.
#228
#218