Stop creation of service entires with dummy endpoints #255
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vrushalijoshi
force-pushed
the
fix-se-creation-with-dummy-endpoints
branch
from
5c054e2
to
9b92b41
Compare
aattuluri
changed the title
aattuluri
changed the title
aattuluri
requested changes
Aug 30, 2022
admiral/pkg/clusters/handler.go
Outdated
| log.Infof(LogFormat+" SE=%s", op, "ServiceEntry", obj.Name, rc.ClusterID, "New SE", obj.Spec.String()) | ||
| } else { | ||
| //se will be created if endpoints are valid, in case they are not valid se will be created with just valid endpoints | ||
| if areEndpointsValid || (!areEndpointsValid && len(validEndpoints) > 0) { |
There was a problem hiding this comment.
It would be simpler if we can filter them inline during validation. Log any filtered endpoints in the method itself.
added 2 commits
August 31, 2022 15:51
Signed-off-by: vjoshi3 <vrushali_joshi@intuit.com>
Signed-off-by: vjoshi3 <vrushali_joshi@intuit.com>
vrushalijoshi
force-pushed
the
fix-se-creation-with-dummy-endpoints
branch
from
b824ccd
to
a44f07a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates to avoid creation of service entry with dummy endpoints. Include updates to delete existing service entry with only dummy endpoints.