Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add default connection pool parameters for generated cnames #257

Merged

Conversation

shriramsharma
Copy link
Collaborator

@shriramsharma shriramsharma commented Aug 31, 2022

This change adds a default HTTP connection pool configuration to the DestinationRule

@aattuluri aattuluri changed the title added default connection pool to DR Add default connection pool to parameters for mesh endpoints Aug 31, 2022
@aattuluri aattuluri changed the title Add default connection pool to parameters for mesh endpoints Add default connection pool to parameters for generated cnames Aug 31, 2022
@aattuluri aattuluri changed the title Add default connection pool to parameters for generated cnames Add default connection pool parameters for generated cnames Aug 31, 2022
Copy link
Contributor

@aattuluri aattuluri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor typo change, looks good otherwise.

admiral/pkg/clusters/handler.go Outdated Show resolved Hide resolved
@codecov-commenter
Copy link

codecov-commenter commented Aug 31, 2022

Codecov Report

Merging #257 (b53217b) into master (05fc3db) will increase coverage by 0.07%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master     #257      +/-   ##
==========================================
+ Coverage   73.02%   73.10%   +0.07%     
==========================================
  Files          31       31              
  Lines        3129     3138       +9     
==========================================
+ Hits         2285     2294       +9     
  Misses        700      700              
  Partials      144      144              
Impacted Files Coverage Δ
admiral/pkg/clusters/handler.go 64.95% <100.00%> (+0.58%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

shriramsharma and others added 2 commits August 31, 2022 09:11
Signed-off-by: Shriram Sharma <shriram_sharma@intuit.com>
Co-authored-by: aattuluri <44482891+aattuluri@users.noreply.github.com>
Signed-off-by: Shriram Sharma <shriram_sharma@intuit.com>
Signed-off-by: Shriram Sharma <shriram_sharma@intuit.com>
Copy link
Contributor

@aattuluri aattuluri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Signed-off-by: Shriram Sharma <shriram_sharma@intuit.com>
Copy link
Contributor

@aattuluri aattuluri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@shriramsharma shriramsharma merged commit f933203 into istio-ecosystem:master Sep 1, 2022
@shriramsharma shriramsharma deleted the default-conn-pool-dr branch September 1, 2022 18:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants