Updating with fixes #258
Merged
Updating with fixes #258
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: vgonuguntla <vinay_gonuguntla@intuit.com>
Signed-off-by: vgonuguntla <vinay_gonuguntla@intuit.com>
Signed-off-by: vgonuguntla <vinay_gonuguntla@intuit.com>
vinay-g
force-pushed
the
MESH-2199-oss
branch
from
0cf2a1f
to
b826e36
Compare
nirvanagit
reviewed
Sep 16, 2022
admiral/pkg/clusters/types_test.go
Outdated
| { | ||
| name: "Readonly test - Routing Policy", | ||
| rp: &v1.RoutingPolicy{ | ||
|
|
There was a problem hiding this comment.
nitpick: remove extra line.
nirvanagit
reviewed
Sep 16, 2022
admiral/pkg/clusters/types_test.go
Outdated
| { | ||
| name: "Readonly false test - Routing Policy", | ||
| rp: &v1.RoutingPolicy{ | ||
|
|
There was a problem hiding this comment.
nitpick: remove extra line.
nirvanagit
reviewed
Sep 16, 2022
admiral/pkg/clusters/types_test.go
Outdated
| t.Run(c.name, func(t *testing.T) { | ||
| if c.readOnly { | ||
| CurrentAdmiralState.ReadOnly = true | ||
| }else{ |
There was a problem hiding this comment.
nitpick: space before/after else.
vinay-g
force-pushed
the
MESH-2199-oss
branch
from
e5cec4b
to
6fac595
Compare
nirvanagit
reviewed
Sep 19, 2022
| @@ -184,3 +186,8 @@ func getHosts(routingPolicy *v1.RoutingPolicy) string { | |||
| hosts = strings.TrimSuffix(hosts, ",") | |||
| return hostsKey + hosts | |||
| } | |||
|
|
|||
| func getPlugin(routingPolicy *v1.RoutingPolicy) string { | |||
| plugin := routingPolicy.Spec.Plugin | |||
There was a problem hiding this comment.
should we check for nil here?
There was a problem hiding this comment.
oops let me add that, its a check in quarter master so that should work
nirvanagit
reviewed
Sep 19, 2022
admiral/pkg/clusters/types_test.go
Outdated
| doesError bool | ||
| }{ | ||
| { | ||
| name: "Readonly test - Routing Policy", |
There was a problem hiding this comment.
may be slightly more context here, for instance what we are trying to assert here.
shriramsharma
approved these changes
Sep 20, 2022
Signed-off-by: vgonuguntla <vinay_gonuguntla@intuit.com>
vinay-g
force-pushed
the
MESH-2199-oss
branch
from
6fac595
to
8e54dda
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
3 Changes -