Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature to exclude an identity via command line parameter #260 #261

Merged
merged 9 commits into from
Oct 3, 2022

Conversation

nirvanagit
Copy link
Collaborator

No description provided.

@nirvanagit nirvanagit requested review from aattuluri and shriramsharma and removed request for aattuluri September 26, 2022 16:23
@aattuluri aattuluri changed the title Feature to exclude an asset via command line parameter #260 Feature to exclude an identity via command line parameter #260 Sep 26, 2022
admiral/cmd/admiral/cmd/root.go Outdated Show resolved Hide resolved
admiral/cmd/admiral/cmd/root.go Outdated Show resolved Hide resolved
admiral/pkg/clusters/types.go Outdated Show resolved Hide resolved
@nirvanagit nirvanagit force-pushed the exclude-asset-list branch 3 times, most recently from 7bdee0b to e38c47b Compare September 29, 2022 16:06
Anubhav Aeron and others added 9 commits September 30, 2022 17:00
Signed-off-by: Anubhav Aeron <anubhav_aeron@intuit.com>
Signed-off-by: Anubhav Aeron <anubhav_aeron@intuit.com>
Signed-off-by: Anubhav Aeron <anubhav_aeron@intuit.com>
Co-authored-by: aattuluri <44482891+aattuluri@users.noreply.github.com>
Signed-off-by: Anubhav Aeron <anubhav_aeron@intuit.com>
Co-authored-by: aattuluri <44482891+aattuluri@users.noreply.github.com>
Signed-off-by: Anubhav Aeron <anubhav_aeron@intuit.com>
Co-authored-by: aattuluri <44482891+aattuluri@users.noreply.github.com>
Signed-off-by: Anubhav Aeron <anubhav_aeron@intuit.com>
Signed-off-by: Anubhav Aeron <anubhav_aeron@intuit.com>
Signed-off-by: Anubhav Aeron <anubhav_aeron@intuit.com>
Signed-off-by: Anubhav Aeron <anubhav_aeron@intuit.com>
@codecov-commenter
Copy link

Codecov Report

Merging #261 (2b3d99d) into master (b371d75) will decrease coverage by 0.04%.
The diff coverage is 60.60%.

@@            Coverage Diff             @@
##           master     #261      +/-   ##
==========================================
- Coverage   73.63%   73.58%   -0.05%     
==========================================
  Files          31       31              
  Lines        3163     3184      +21     
==========================================
+ Hits         2329     2343      +14     
- Misses        688      691       +3     
- Partials      146      150       +4     
Impacted Files Coverage Δ
admiral/pkg/clusters/handler.go 67.96% <ø> (ø)
admiral/pkg/controller/common/types.go 86.66% <ø> (ø)
admiral/pkg/clusters/serviceentry.go 80.40% <50.00%> (-0.18%) ⬇️
admiral/pkg/controller/common/config.go 73.77% <60.00%> (-1.67%) ⬇️
admiral/pkg/clusters/types.go 58.36% <62.50%> (+0.14%) ⬆️
admiral/pkg/clusters/util.go 85.39% <75.00%> (-1.52%) ⬇️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Contributor

@aattuluri aattuluri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm

@nirvanagit nirvanagit merged commit 54ffcb1 into master Oct 3, 2022
@nirvanagit nirvanagit deleted the exclude-asset-list branch October 3, 2022 16:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants