fix: Handle VS hosts nil #265
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: nbn01 <nandan_bn@intuit.com>
itsLucario
force-pushed
the
vs-nil-check-patch
branch
from
5c34cb6
to
928fb79
Compare
nirvanagit
reviewed
Nov 7, 2022
admiral/pkg/clusters/handler.go
Outdated
| if err != nil { | ||
| if k8sErrors.IsNotFound(err) { | ||
| log.Infof(LogFormat, "Delete", "VirtualService", obj.Name, clusterId, "Either VirtualService was already deleted, or it never existed") | ||
| if virtualService.Hosts != nil { |
There was a problem hiding this comment.
Its better to check the length of the slice, because if an empty []string is assigned to virtualService.Hosts then it will not be nil.
There was a problem hiding this comment.
Ah, Right!! I've updated
Signed-off-by: nbn01 <nandan_bn@intuit.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
VS hosts field is an optional field in Istio's VirtualService CRD spec. It'll be nil when we want to create a delegate Virtual Service.
The fix will do a
nilcheck and if the VS hosts are nil, the admiral will replicate the VS resource as it is within all the clusters.