Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updating kustomize version and adding apple silicon instructions #275

Merged
merged 1 commit into from
Jan 24, 2023

Conversation

vinay-g
Copy link
Collaborator

@vinay-g vinay-g commented Jan 17, 2023

Updating instructions for apple silicon, updating kustomize as 3.8.2 version is not supported in apple silicon.

Copy link
Contributor

@aattuluri aattuluri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Signed-off-by: vgonuguntla <vinay_gonuguntla@intuit.com>
@vinay-g
Copy link
Collaborator Author

vinay-g commented Jan 18, 2023

@shriramsharma can you take a look

@codecov-commenter
Copy link

Codecov Report

Merging #275 (8745ea2) into master (5541b68) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #275   +/-   ##
=======================================
  Coverage   72.78%   72.78%           
=======================================
  Files          27       27           
  Lines        2657     2657           
=======================================
  Hits         1934     1934           
  Misses        601      601           
  Partials      122      122           

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@vinay-g vinay-g merged commit 61b8378 into istio-ecosystem:master Jan 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants