Adding labels to admiral generated service entries #281
Conversation
| } | ||
| if seDr.SeDnsPrefix != "" && seDr.SeDnsPrefix != common.Default { | ||
| newServiceEntry.Labels["dnsPrefix"] = seDr.SeDnsPrefix | ||
| } |
There was a problem hiding this comment.
Based on this spec for label names, the above might not work. We can have dns-prefix?
Also why labels and not an annotations? Are you using this as filter for querying?
There was a problem hiding this comment.
Good catch will update the name, having said that when I tested it on a test cluster it did create SE with this label. I don't see use case where we might need to filter based on dns prefix or GTP, will update these to be annotation.
Will keep env as label, since identity is today getting added and label, and may be required to filter endpoints, let me know if this is ok?
There was a problem hiding this comment.
cool, updated code based on this
Codecov Report
📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more @@ Coverage Diff @@
## master #281 +/- ##
==========================================
+ Coverage 74.18% 74.22% +0.04%
==========================================
Files 32 32
Lines 3266 3279 +13
==========================================
+ Hits 2423 2434 +11
- Misses 695 697 +2
Partials 148 148
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Signed-off-by: vjoshi3 <vrushali_joshi@intuit.com>
Signed-off-by: vjoshi3 <vrushali_joshi@intuit.com>
vrushalijoshi
force-pushed
the
update-se-annotation-labels
branch
from
263bba8
to
3d83184
Compare
Update to SE modification flow, in order to add env, prefix and associated GTP details to SE labels.