prevent panic when cluster does not contain rollout OR deployment for given asset #286
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nirvanagit
force-pushed
the
fix-label-panic
branch
from
a1ed70f
to
d412ed4
Compare
admiral/pkg/clusters/util.go
Outdated
| return nil, nil | ||
| } | ||
|
|
||
| func GetMeshPortsForDeployment(clusterName string, destService *k8sV1.Service, | ||
| destDeployment *k8sAppsV1.Deployment) map[string]uint32 { | ||
| var meshPorts = destDeployment.Spec.Template.Annotations[common.SidecarEnabledPorts] |
There was a problem hiding this comment.
@nirvanagit , should we add a nil check here on destDeployment?
There was a problem hiding this comment.
Yes absolutely.
added 2 commits
March 10, 2023 15:05
… given asset Signed-off-by: Anubhav Aeron <anubhav_aeron@intuit.com>
Signed-off-by: Anubhav Aeron <anubhav_aeron@intuit.com>
nirvanagit
force-pushed
the
fix-label-panic
branch
from
8316a93
to
ff014c3
Compare
shriramsharma
approved these changes
Mar 10, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.